FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-110383: Remove references to removed popen[234] by shenanigansd · Pull Request #112783 · python/cpython · GitHub

/ cpython Public

gh-110383: Remove references to removed popen[234] - #112783

Merged
encukou merged 4 commits into
python:mainfrom
shenanigansd:br/remove-references-to-popen+
May 30, 2024
Merged

gh-110383: Remove references to removed popen[234]#112783
encukou merged 4 commits into
python:mainfrom
shenanigansd:br/remove-references-to-popen+

Conversation

shenanigansd commented Dec 6, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Continues #110383
Originally reported in https://mail.python.org/archives/list/docs@python.org/thread/4AYZNSW3RB3DNT5C7JEE6RCESBWIKZTD/

Remove recommendations for migrating away from os.popen2, os.popen3, os.popen4, and popen2, which haven't existed since Python 2.7.

Leaves the recommendations for os.popen, which does still exist.


📚 Documentation preview 📚: https://cpython-previews--112783.org.readthedocs.build/

These functions were removed in Python 3.

Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 6, 2023

Copy link
Copy Markdown
Contributor

Would this section also need to be reviewed? https://github.com/python/cpython/blob/main/Doc/faq/library.rst?plain=1#L538-L582

They have been commented out since 2009: 9e4ff75

shenanigansd commented Dec 20, 2023
edited
Loading

Copy link
Copy Markdown
Contributor Author

Upon review, that section was commented out in 2009 (9e4ff75)
If it hasn't been needed since then, we should probably go ahead and remove it.

I've gone ahead and removed it in f84d6d4

encukou enabled auto-merge (squash) May 30, 2024 12:03
encukou merged commit b1374aa into python:main May 30, 2024
shenanigansd deleted the br/remove-references-to-popen+ branch May 30, 2024 15:22
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…2783)


Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…2783)


Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL