Repository navigation
gh-101100: Fix Sphinx warning in library/http.cookies.rst - #112908
Merged
hugovk merged 3 commits intoDec 10, 2023
Merged
hugovk merged 3 commits into
hugovk merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AlexWaygood
reviewed
Dec 10, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks great overall! A few small suggestions:
Sorry, something went wrong.
Comment thread
Doc/library/http.cookies.rst
Outdated
Comment thread
Doc/library/http.cookies.rst
Outdated
Comment thread
Doc/library/http.cookies.rst
Outdated
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Dec 10, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🍪🎉
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-112929 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-112930 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 10, 2023
…onGH-112908) (cherry picked from commit 7595d47) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 10, 2023
…onGH-112908) (cherry picked from commit 7595d47) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk
added a commit
that referenced
this pull request
Dec 10, 2023
hugovk
added a commit
that referenced
this pull request
Dec 10, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…on#112908) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…on#112908) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix these warnings:
Plus refer to MSIE 3.0x in the past tense (EOL since something like 2003! Should we even remove that bit?), make cookie lowercase, adjust some formatting.
📚 Documentation preview 📚: https://cpython-previews--112908.org.readthedocs.build/en/112908/library/http.cookies.html