Repository navigation
gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows - #113049
Merged
serhiy-storchaka merged 14 commits intoDec 14, 2023
Merged
serhiy-storchaka merged 14 commits into
serhiy-storchaka merged 14 commits into
Conversation
serhiy-storchaka
force-pushed
the
win-chmod-follow-symlinks
branch
from
15c667b to
0d117a1
Compare
December 13, 2023 11:50
serhiy-storchaka
marked this pull request as ready for review
December 13, 2023 15:09
serhiy-storchaka
requested review from
AlexWaygood and
erlend-aasland
as code owners
December 13, 2023 15:09
AlexWaygood
removed their request for review
December 13, 2023 16:51
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with two PEP-7 nits and two cases where we should be explicitly ignoring the return value (-Wunused-result).
Sorry, something went wrong.
Comment thread
Modules/posixmodule.c
Outdated
Comment thread
Modules/posixmodule.c
Outdated
Comment thread
Modules/posixmodule.c
Outdated
Comment thread
Modules/posixmodule.c
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.