FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix Sphinx nitpicks in `library/collections.abc.rst` by AlexWaygood · Pull Request #113116 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix Sphinx nitpicks in library/collections.abc.rst - #113116

Merged
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:collections-abc-nitpicks
Dec 14, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-101100: Fix Sphinx nitpicks in library/collections.abc.rst#113116
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:collections-abc-nitpicks

Conversation

AlexWaygood commented Dec 14, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Dec 14, 2023
Closed

rhettinger commented Dec 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please leave the double-back-ticks as they are now. They were intentionally just inline code and not links which as no value and are distracting to a reader.

AlexWaygood commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

Please leave the double-back-ticks as they are now. They were intentionally just inline code and not links which as no value and are distracting to a reader.

Sure -- I've reverted those changes

rhettinger approved these changes Dec 14, 2023
View reviewed changes
Comment thread Doc/library/collections.abc.rst
Comment thread Doc/library/collections.abc.rst
Comment thread Doc/library/collections.abc.rst
Comment thread Doc/library/collections.abc.rst
subclassing.

.. [2] Checking ``isinstance(obj, Iterable)`` detects classes that are
registered as :class:`Iterable` or that have an :meth:`__iter__`

rhettinger Dec 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same here.

AlexWaygood Dec 14, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the added link here (to __iter__ methods) is pertinent and useful, as it relates to the definition of what an iterable is. The other methods in this footnote also have links to their documentation.

Comment thread Doc/library/collections.abc.rst
AlexWaygood merged commit 006355b into python:main Dec 14, 2023
AlexWaygood deleted the collections-abc-nitpicks branch December 14, 2023 19:25

miss-islington-app Bot commented Dec 14, 2023

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-app Bot commented Dec 14, 2023

Copy link
Copy Markdown

GH-113136 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2023
pythongh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (…
73bed9a 
…pythonGH-113116)

(cherry picked from commit 006355b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 14, 2023

bedevere-app Bot commented Dec 14, 2023

Copy link
Copy Markdown

GH-113137 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2023
pythongh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (…
f0ba6a5 
…pythonGH-113116)

(cherry picked from commit 006355b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-app Bot removed the needs backport to 3.11 only security fixes label Dec 14, 2023
AlexWaygood added a commit that referenced this pull request Dec 14, 2023
[3.12] gh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (
1511451 
GH-113116) (#113136)

gh-101100: Fix Sphinx nitpicks in `library/collections.abc.rst` (GH-113116)
(cherry picked from commit 006355b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 14, 2023
[3.11] gh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (
ba69585 
GH-113116) (#113137)

gh-101100: Fix Sphinx nitpicks in `library/collections.abc.rst` (GH-113116)
(cherry picked from commit 006355b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023
pythongh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (…
adb433e 
…python#113116)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (…
5aec05e 
…python#113116)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-101100: Fix Sphinx nitpicks in library/collections.abc.rst (…
1e983b1 
…python#113116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rhettinger rhettinger approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL