FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS by ronaldoussoren · Pull Request #113213 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS - #113213

Merged
ned-deily merged 1 commit into
python:mainfrom
ronaldoussoren:gh-108269
Dec 18, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS#113213
ned-deily merged 1 commit into
python:mainfrom
ronaldoussoren:gh-108269

Conversation

ronaldoussoren commented Dec 16, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adding this key with a value of true enables detecting the users prefered language in libraries accessing system APIs for this.

pythongh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on…
7279307 
… macOS

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
ronaldoussoren self-assigned this Dec 16, 2023
ronaldoussoren requested a review from a team as a code owner December 16, 2023 10:47
bedevere-app Bot mentioned this pull request Dec 16, 2023
Closed

ronaldoussoren commented Dec 17, 2023

Copy link
Copy Markdown
Contributor Author

@ned-deily, what's your opinion on back porting this to 3.11 and 3.12?

I'm leaning toward seeing this a more as a new feature that shouldn't be back ported, but might be too conservative here. Anyone packaging GUI apps using py2app or pyinstaller can already set the Info.plist property for their app and this only affects command-line usage. Backporting should be safe enough.

ned-deily commented Dec 18, 2023

Copy link
Copy Markdown
Member

@ned-deily, what's your opinion on back porting this to 3.11 and 3.12?

This seems like something that could be considered either a bug or a feature. I don't have a strong opinion one way or the other. As you say, it's easy enough to work around when bundling an app. But it might be nice to fix. Perhaps compromise and just backport to 3.12 since it's still relatively early in its release cycle?

ned-deily merged commit 4cfce3a into python:main Dec 18, 2023

ned-deily commented Dec 18, 2023

Copy link
Copy Markdown
Member

I merged this PR so that it will get exposure in the upcoming 3.13.0a3 preview. I will leave the backport decision to @ronaldoussoren.

ronaldoussoren added the needs backport to 3.12 only security fixes label Dec 19, 2023

miss-islington-app Bot commented Dec 19, 2023

Copy link
Copy Markdown

Thanks @ronaldoussoren for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2023
pythongh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on…
0184bd5 
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>

bedevere-app Bot commented Dec 19, 2023

Copy link
Copy Markdown

GH-113294 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 19, 2023

ronaldoussoren commented Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

I'm going to be conservative with the back port and only back port to 3.12.

ronaldoussoren added a commit that referenced this pull request Dec 19, 2023
[3.12] gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist o…
376b46d 
…n macOS (GH-113213) (#113294)

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS (GH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
pythongh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on…
345884e 
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on…
2310748 
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on…
26a2337 
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes

Assignees

ronaldoussoren

Labels

OS-mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL