FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113299: Create libclinic package by vstinner · Pull Request #113309 · python/cpython · GitHub

/ cpython Public

gh-113299: Create libclinic package - #113309

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:libclinic_converters
ConversationCommits (1)ChecksFiles changed
Closed

gh-113299: Create libclinic package#113309
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:libclinic_converters

Conversation

vstinner commented Dec 20, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Create Tools/clinic/libclinic/ package.
  • Move cpp.py to libclinic.
  • Create libclinic.utils.

pythongh-113299: Create libclinic package
b58b260 
* Create Tools/clinic/libclinic/ package.
* Move cpp.py to libclinic.
* Create libclinic.utils.
bedevere-app Bot mentioned this pull request Dec 20, 2023
Closed

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland @AlexWaygood @corona10: Ok, here is first minimum step to create a new package for Argument Clinic code.

AlexWaygood reviewed Dec 20, 2023
View reviewed changes
Comment thread Tools/clinic/libclinic/utils.py


# Clinic instance
clinic: 'Clinic' | None = None

AlexWaygood Dec 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment)

erlend-aasland reviewed Dec 20, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py

global clinic
clinic = self
utils.clinic = self

erlend-aasland Dec 20, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IMO, putting a global from one file into another file is not a good idea.

vstinner commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland:

IMO, putting a global from one file into another file is not a good idea.

I don't have the bandwidth right now to move this global variable. Adding utils.clinic variable is a temporary solution until someone can spend time to work on it. I gave on my latest attempt to partially fix the issue since nobody was available to review my work: #110984

Apparently, it's a requirement for @AlexWaygood and @erlend-aasland so I prefer to close this PR for now.

vstinner closed this Dec 20, 2023
erlend-aasland mentioned this pull request Dec 20, 2023
Closed
vstinner deleted the libclinic_converters branch December 20, 2023 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland left review comments
AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL