Repository navigation
gh-113329: Catch OSError in doctest finder and document that inspect.getsourcefile/getfile can raise OSError - #113335
serhiy-storchaka merged 4 commits into
Conversation
Sorry, something went wrong.
Fixes python#113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Documentation build overview2 files changed ± library/inspect.html ± whatsnew/changelog.html |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
|
Thanks @stenwessel for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
|
GH-155658 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
|
GH-155659 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-155660 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…nspect.getsourcefile/getfile can raise OSError (GH-113335) (GH-155659) Fixes GH-113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found. (cherry picked from commit 025e7d2) Co-authored-by: Sten Wessel <sten@stenwessel.nl>
…nspect.getsourcefile/getfile can raise OSError (GH-113335) (GH-155660) Fixes GH-113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found. (cherry picked from commit 025e7d2) Co-authored-by: Sten Wessel <sten@stenwessel.nl>
…nspect.getsourcefile/getfile can raise OSError (GH-113335) (#155658) gh-113329: Catch OSError in doctest finder and document that inspect.getsourcefile/getfile can raise OSError (GH-113335) Fixes GH-113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found. (cherry picked from commit 025e7d2) Co-authored-by: Sten Wessel <sten@stenwessel.nl>
…spect.getsourcefile/getfile can raise OSError (pythonGH-113335) Fixes python#113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found.
Fixes #113329, which occurs when running doctests in a class docstring in a REPL environment. Since Python 3.10, an OSError is raised when the class source code cannot be found.
Just as inspect.getsourcelines, this PR adds documentation for inspect.getsourcefile and inspect.getfile that it can raise an OSError when the source code cannot be found.
Additionally, this PR now also catches OSError in the doctest finder. The source code is only necessary to discover line numbers, and is already ignored when a TypeError occurs. This restores behavior from CPython version < 3.10 where doctests can be found on a class object in the REPL (and, in particular, also in notebook environments).
📚 Documentation preview 📚: https://cpython-previews--113335.org.readthedocs.build/