gh-110383: Fix docstring for str.rsplit maxsplit param to 'starting from the right' - #113353
gh-110383: Fix docstring for str.rsplit maxsplit param to 'starting from the right'#113353sparrowt wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Previously the parameters including their docstrings were cloned from `str.split` but that says 'starting from the left' which is not correct for `str.rsplit`. It is not possible to partially clone or modify according to: https://devguide.python.org/development-tools/clinic/#how-to-clone-existing-functions so copy from `split` and modify as necessary.
|
I propose a different approach in #113355. |
Sorry, something went wrong.
|
Thanks for your PR. While this approach fixes the problem, I hesitate with it slightly, since it duplicates a lot of lines. For example, we will now have to make sure both strip and rstrip are updated if the param docstring needs amendment in the future. I propose instead to change the wording in the param docstring, and instead clarify how the two functions operate in the docstring body. I'm not sure which variant is clearest for the user. |
Sorry, something went wrong.
|
Thanks for your interest in improving CPython :) |
Sorry, something went wrong.
|
Fair enough, thanks! |
Sorry, something went wrong.
Previously the parameters including their docstrings were cloned from str.split but that says 'starting from the left' which is not correct for str.rsplit.
It is not possible to partially clone or modify according to: https://devguide.python.org/development-tools/clinic/#how-to-clone-existing-functions so copy from split and modify as necessary.
This follows on from #111247 hopefully addressing the feedback there.