gh-112302: Point core developers to SBOM devguide on errors - #113490
Merged
hugovk merged 3 commits intoJan 10, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sethmlarson
force-pushed
the
sbom-devguide-on-error
branch
from
656e222 to
964d596
Compare
December 26, 2023 14:51
sethmlarson
force-pushed
the
sbom-devguide-on-error
branch
from
964d596 to
fc699a0
Compare
December 26, 2023 15:00
hugovk
reviewed
Dec 28, 2023
Comment thread
Tools/build/generate_sbom.py
Outdated
hugovk
approved these changes
Jan 10, 2024
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
Tools/build/generate_sbom.py
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
Last suggestion committed, thanks @hugovk for the reviews! :) |
Sorry, something went wrong.
hugovk
enabled auto-merge (squash)
January 10, 2024 19:10
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…thon#113490) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…thon#113490) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…thon#113490) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from python/devguide#1251, this adds a helper which errors out during validation and provides a helpful link to the SBOM devguide.