FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113560: Improve docs for `set.issubset` and `set.issuperset` by CharlieZhao95 · Pull Request #113562 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-113560: Improve docs for set.issubset and set.issuperset - #113562

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
CharlieZhao95:doc/issubset
Jan 27, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-113560: Improve docs for set.issubset and set.issuperset#113562
serhiy-storchaka merged 3 commits into
python:mainfrom
CharlieZhao95:doc/issubset

Conversation

CharlieZhao95 commented Dec 29, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Dec 29, 2023
Closed
sobolevn reviewed Dec 29, 2023
View reviewed changes
Comment thread Objects/setobject.c Outdated
"issubset($self, /, other)\n\
--\n\
\n\
Return True if all elements in this set are found in other(iterable).");

sobolevn Dec 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why do you use other() as a callable?

Suggested change
Return True if all elements in this set are found in other(iterable).");
Return True if all elements in this set are found in other iterable.");

CharlieZhao95 Dec 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why do you use other() as a callable?

I just want to explain that the parameter other is an iterable :) Perhaps it would be better to replace other with iterable? 🤔

serhiy-storchaka reviewed Jan 26, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The documentation in Doc/library/stdtypes.rst is short enough to be used as a docstring.

CharlieZhao95 commented Jan 27, 2024

Copy link
Copy Markdown
Contributor Author

The documentation in Doc/library/stdtypes.rst is short enough to be used as a docstring.

Thanks. This change looks good. updated! :)

serhiy-storchaka reviewed Jan 27, 2024
View reviewed changes
Comment thread Objects/setobject.c Outdated
serhiy-storchaka approved these changes Jan 27, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka enabled auto-merge (squash) January 27, 2024 09:29
serhiy-storchaka merged commit 11c5822 into python:main Jan 27, 2024
serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 27, 2024

miss-islington-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

Thanks @CharlieZhao95 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
212a71c 
…rset() (pythonGH-113562)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
0babe18 
…rset() (pythonGH-113562)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>

bedevere-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

GH-114643 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 27, 2024

bedevere-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

GH-114644 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 27, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 27, 2024
[3.11] gh-113560: Improve docstrings for set.issubset() and set.issup…
2179948 
…erset() (GH-113562) (GH-114643)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
serhiy-storchaka pushed a commit that referenced this pull request Jan 27, 2024
[3.12] gh-113560: Improve docstrings for set.issubset() and set.issup…
5c21f3d 
…erset() (GH-113562) (GH-114644)

(cherry picked from commit 11c5822)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-113560: Improve docstrings for set.issubset() and set.issupe…
06c9713 
…rset() (pythonGH-113562)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn left review comments
serhiy-storchaka serhiy-storchaka approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL