| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
The check about the f argument type was removed in this commit: python@2c94aa5 Thanks for Pedro Arthur Duarte (pedroarthur.jedi at gmail.com) by the help with this bug.
…#106335) Remove private _PyThreadState and _PyInterpreterState C API functions: move them to the internal C API (pycore_pystate.h and pycore_interp.h). Don't export most of these functions anymore, but still export functions used by tests. Remove _PyThreadState_Prealloc() and _PyThreadState_Init() from the C API, but keep it in the stable API.
There was a problem hiding this comment.
Looks good, one comment.
Sorry, something went wrong.
|
|
||
| Special read-only attributes: | ||
| Special read-only attributes | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
I don't think it really makes sense to make this a separate subsection, since there are no other subsections inside the datamodel section on instance methods. I'd just keep this as a sentence ending with a colon, personally
Sorry, something went wrong.
| the module the function was defined in or ``None`` if unavailable. | ||
| See :attr:`function.__module__`. | ||
| Special read-only attributes | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Same here, I'm not sure it really makes sense to make this a distinct subsection when there aren't any other subsections inside the datamodel section on builtin functions
Sorry, something went wrong.
There was a problem hiding this comment.
I thought about that, and I decided by subsection because:
Actually, when I opened the issue, I thought about a unique table for both attributes with a column to identify the kind, as the User-defined functions section was before your recent changes.
Sorry, something went wrong.
There was a problem hiding this comment.
Those are all reasonable points! I don't mind the new subsection in the section on builtin functions too much; I'm happy for that to stay.
I do think the new subsection in the section on instance methods makes it more confusing, however. It implies that the entirety of the section on instance methods is about their special read-only attributes, except for the first paragraph. This isn't true: the final paragraph in section 3.2.8.2 has nothing to do with the special read-only methods of instance methods:
Note that the transformation from function object to instance method object happens each time the attribute is retrieved from the instance. In some cases, a fruitful optimization is to assign the attribute to a local variable and call that local variable. Also notice that this transformation only happens for user-defined functions; other callable objects (and all non-callable objects) are retrieved without transformation. It is also important to note that user-defined functions which are attributes of a class instance are not converted to bound methods; this only happens when the function is an attribute of the class.
Sorry, something went wrong.
There was a problem hiding this comment.
What if do we move this paragraph to the second paragraph? This seems an explanation for the first one.
Sorry, something went wrong.
There was a problem hiding this comment.
Well, what about these two paragraphs?
When an instance method object is created by retrieving a classmethod object from a class or instance, its __self__ attribute is the class itself, and its __func__ attribute is the function object underlying the class method.
When an instance method object is called, the underlying function (__func__) is called, inserting the class instance (__self__) in front of the argument list. For instance, when C is a class which contains a definition for a function f(), and x is an instance of C, calling x.f(1) is equivalent to calling C.f(x, 1).
The first paragraph is about the special read-only attributes of method objects; the second one isn't (it's about a broader topic to do with the semantics of Python methods). So maybe we should move the second paragraph out of the section about the special read-only attributes -- but that would make no sense; it's much more logical to talk about how the self reference is inserted at the beginning of the argument list after we've talked about the special __self__ attribute. The two paragraphs belong together.
For the section on instance methods, I think the existing structure -- where the special read-only attributes are discussed at the same time as other details on method semantics -- makes most sense. Unless you want to propose reworking the whole section on instance methods (which should go into a separate PR, IMO), I don't think we should add a subsection just for the read-only attributes.
Sorry, something went wrong.
There was a problem hiding this comment.
it's about a broader topic to do with the semantics of Python methods
Despite this, I think that we can consider all these paragraphs as about the attributes. They talk about how the attributes work together to element (object, class, method..) to work as well. The attributes are cited a lot of time.
In first look, I understand this paragraph under attributes this way. However, I also noted some paragraphs didn't are about the attribute, but about the element. I would propose moving these paragraphs to the introduction of the section, probrably.
Another two idea are:
I prefer first option (although more work), but the second one also provide consistence.
Unless you want to propose reworking the whole section on instance methods (which should go into a separate PR, IMO),
Shall we do this together. Some details about it can scape me. :) I think what I told above is in this direction.
(Sorry for any confused thought. It is a brainstorm)
Sorry, something went wrong.
There was a problem hiding this comment.
I'm sorry, but I still disagree that using a subsection for the Instance methods section is the right way to go there, at least the way you've currently done it in this PR :/ I'd be happy to look at a broader rewrite of that section, because I agree that consistency between the different sections is nice. But unfortunately I don't really have time to push forward on that right now (and I doubt I will until PyCon).
Sorry, something went wrong.
| * - .. attribute:: builtin_function.__class__ | ||
| - The function's class. | ||
|
|
There was a problem hiding this comment.
This attribute is present on all Python objects everywhere, and is already documented as such here: https://docs.python.org/3/library/stdtypes.html#special-attributes. Please revert this addition; there's no need to duplicate that documentation here.
| * - .. attribute:: builtin_function.__class__ | |
| - The function's class. |
Sorry, something went wrong.
There was a problem hiding this comment.
In fact, I've realized that attribute definition duplication is a problem in this chapter. See __doc__ and __name__ attributes, e.g.
I'm thinking about a kind of hierarchy: a section with all common attributes and in each callable type something like "the attributes are those above plus these more: ... ". The content that you highlighted now is a good beginning in this direction. However, Reference Language must be referenced by the Library Reference. Besides, we don't have a reference to the cited content in this chapter.
Also, I found the attribute definitions in the inspect module documentation. This could be erased and added a refer to the Language Reference.
In my opinion, the Language Reference is more important than other sections. All other sections must refer to the Reference, not the contrary.
So, my suggestion is:
What do you think? Any other ideas?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, I've been working towards similar goals to you in my recent PRs #112781, #112933, #112735, etc. My opinions:
Sorry, something went wrong.
There was a problem hiding this comment.
- For attributes that really do exist on all objects everywhere, like __class__ and __dict__, the list in stdtypes.rst is useful. We should keep the list for things like that. Maybe the list should be moved out of stdtypes.rst and into the datamodel somewhere, but that's a separate question from whether we should keep the list or not, and I think we should keep the list.
My suggestion is to put the list on The standard type hierarchy. The second paragraph already cited special attributes, so this seems like a good place to show them.
Does it make sense for you?
Sorry, something went wrong.
There was a problem hiding this comment.
Some things have changed since we had this conversation in March!
Now, __class__ and __dict__ are documented as object.__class__ and object.__dict__, because they are present on all Python objects: https://docs.python.org/3/reference/datamodel.html#object.__class__, https://docs.python.org/3/reference/datamodel.html#object.__dict__. But __name__ and __doc__ are now more consistently listed for classes documented in the data model that define these attributes, and they are still listed in https://docs.python.org/3/library/stdtypes.html#special-attributes (because they do not exist on all Python objects).
All things considered, I still think it's incorrect for the __class__ attribute to be documented here, since it doesn't really add anything to the documentation at https://docs.python.org/3/reference/datamodel.html#object.__class__. So my original request remains: please get rid of this bullet point :-)
My suggestion is to put the list on The standard type hierarchy. The second paragraph already cited special attributes, so this seems like a good place to show them.
Let's have this conversation in an issue or PR elsewhere; the question doesn't really seem relevant to this PR :-) Maybe the list should be moved out of stdtypes into the datamodel, and maybe not -- whatever the case, I don't think it should be done as part of this PR :-)
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
I've committed the __self__ change. However, look at #58211. |
Sorry, something went wrong.
Oh, interesting. Hmm, not sure what we should do here. It seems like a misfeature, at best, that __self__ is set to module objects for builtin functions -- so maybe we shouldn't document that. Maybe the best course of action would be to say something a bit more vague like "While this may exist as an attribute on builtin function objects, its value is never meaningful (but see [section on builtin methods])". @hugovk any thoughts? |
Sorry, something went wrong.
In this PR, I'm unsure because the module object (the currently __self__ value) is significant. This discussion must be on the issue that I cited. I proposed PR #113575 with the test to the __self__, and I'm waiting for this PR to be merged to include the doc in that PR. In the worst scenario, the discussion about that will be reopened. So, two ideas:
|
Sorry, something went wrong.
|
@hugovk, do you have any direction here? I'd like to make a decision at this point and then apply it to the next document sections. |
Sorry, something went wrong.
|
The update on the conversation regarding __self__ is that it looks like #113575 might be accepted, but it's still awaiting changes that Serhiy asked for (and which I agree with) |
Sorry, something went wrong.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
📚 Documentation preview 📚: https://cpython-previews--113574.org.readthedocs.build/en/113574/reference/datamodel.html