FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113538: Don't crash in stream reader protocol callback when task is cancelled by gvanrossum · Pull Request #113690 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-113538: Don't crash in stream reader protocol callback when task is cancelled - #113690

Merged
gvanrossum merged 3 commits into
python:mainfrom
gvanrossum:asyncio-streams-fix
Jan 4, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-113538: Don't crash in stream reader protocol callback when task is cancelled#113690
gvanrossum merged 3 commits into
python:mainfrom
gvanrossum:asyncio-streams-fix

Conversation

gvanrossum commented Jan 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

That callback exists purely to log an error when the coroutine running in the task raises an exception. But if the task was cancelled instead, the callback itself crashes, which just logs noise. In that case we should just close the transport without logging anything.

CC @jsundahl

bedevere-app Bot mentioned this pull request Jan 3, 2024
Closed

itamaro commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

is there a test case we can add that would cover the issue and fix?

jsundahl approved these changes Jan 4, 2024
View reviewed changes

jsundahl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good, I do think closing the transport if the task is cancelled is the correct thing to do.

itamaro approved these changes Jan 4, 2024
View reviewed changes

itamaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for adding a test case! LG!

gvanrossum merged commit 4681a52 into python:main Jan 4, 2024

miss-islington-app Bot commented Jan 4, 2024

Copy link
Copy Markdown

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

gvanrossum deleted the asyncio-streams-fix branch January 4, 2024 20:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2024
pythongh-113538: Don't error in stream reader protocol callback when …
d492487 
…task is cancelled (pythonGH-113690)

(cherry picked from commit 4681a52)

Co-authored-by: Guido van Rossum <guido@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2024
pythongh-113538: Don't error in stream reader protocol callback when …
6429b46 
…task is cancelled (pythonGH-113690)

(cherry picked from commit 4681a52)

Co-authored-by: Guido van Rossum <guido@python.org>

bedevere-app Bot commented Jan 4, 2024

Copy link
Copy Markdown

GH-113713 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 4, 2024

bedevere-app Bot commented Jan 4, 2024

Copy link
Copy Markdown

GH-113714 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 4, 2024
gvanrossum added a commit that referenced this pull request Jan 4, 2024
[3.11] gh-113538: Don't error in stream reader protocol callback when…
456e2ec 
… task is cancelled (GH-113690) (#113714)

(cherry picked from commit 4681a52)

Co-authored-by: Guido van Rossum <guido@python.org>
gvanrossum added a commit that referenced this pull request Jan 4, 2024
[3.12] gh-113538: Don't error in stream reader protocol callback when…
92ba4e1 
… task is cancelled (GH-113690) (#113713)

(cherry picked from commit 4681a52)

Co-authored-by: Guido van Rossum <guido@python.org>
mhils mentioned this pull request Jan 21, 2024
Closed
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-113538: Don't error in stream reader protocol callback when …
805e16a 
…task is cancelled (python#113690)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-113538: Don't error in stream reader protocol callback when …
8c17f66 
…task is cancelled (python#113690)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-113538: Don't error in stream reader protocol callback when …
b063464 
…task is cancelled (python#113690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

itamaro itamaro approved these changes
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
+1 more reviewer
jsundahl jsundahl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL