Repository navigation
gh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_CallNoArgs as returning a strong reference - #113697
Merged
erlend-aasland merged 2 commits intoJan 4, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 4, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2024
…NoArgs as returning a strong reference (pythonGH-113697) (cherry picked from commit 1ae7ceb) Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
Copy link
Copy Markdown
|
GH-113698 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2024
…NoArgs as returning a strong reference (pythonGH-113697) (cherry picked from commit 1ae7ceb) Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
Copy link
Copy Markdown
|
GH-113699 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 5, 2024
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 5, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…NoArgs as returning a strong reference (python#113697)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…NoArgs as returning a strong reference (python#113697)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…NoArgs as returning a strong reference (python#113697)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_CallOneArg and PyObject_CallNoArgs should be updated in the docs with the reference count annotation "Return value: New reference." (as is the case with PyObject_CallFunction et al.)
📚 Documentation preview 📚: https://cpython-previews--113697.org.readthedocs.build/