Repository navigation
gh-113924: Allow pre-compressed data to be written into a zip via zipfile. - #113925
gpshead wants to merge 3 commits into
Conversation
Sorry, something went wrong.
Intended to be used when constructing zip files via a system that can parallelize and cache all actions including compressing individual input file contents so that you can distribute actions & avoid recomputation.
| f"Bad CRC-32 for file {self.name!r} expected " | ||
| f"{hex(self._expected_crc)} != {hex(self._running_crc)}") |
There was a problem hiding this comment.
Did you keep the beginning of the error message identical to keep compatibility?
If not, then it could be easier to read if it was like bad crc32 {got value} for file {name}, expected {expected value}. For now it’s slightly unpleasant to read about bad value, expected, expected, bad.
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
This PR is superseded by #125718, a newer open pull request for the same issue (gh-113924), and it no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer. |
Sorry, something went wrong.
Intended to be used when constructing zip files via a system that can parallelize and cache all actions including compressing individual input file contents so that you can distribute actions & avoid recomputation.
This also adds the missing ability to pass in pre-constructed ZipInfo to the write method as pre-compressed data needs its original file_size and uncompressed data CRC to also have been pre-computed.