FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-113655: Lower the C recursion limit on various platforms by markshannon · Pull Request #113944 · python/cpython · GitHub

/ cpython Public

GH-113655: Lower the C recursion limit on various platforms - #113944

Merged
markshannon merged 15 commits into
python:mainfrom
faster-cpython:lower-c-recursion-limit-for-windows
Jan 16, 2024
ConversationCommits (15)ChecksFiles changed
Merged

GH-113655: Lower the C recursion limit on various platforms#113944
markshannon merged 15 commits into
python:mainfrom
faster-cpython:lower-c-recursion-limit-for-windows

Conversation

markshannon commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Lower the C recursion for Windows, s390x, and address sanitizer builds.
Remove the COMPILER_STACK_FRAME_SCALE multiplier as it longer makes sense with the higher recursion limits.
Up the C recursion a bit for Mac and Linux
Add a test.

Experimentation by me and @mdboom (#113668) show that 4000 is a good limit for Windows. I was seeing stack overflows at 5000.

Ideally, we will use proper stack checking in the future, #113655 (comment), but that's probably too invasive a change for 3.12.

markshannon changed the title Lower the C recursion limit on Windows GH-113655: Lower the C recursion limit on Windows Jan 11, 2024
bedevere-app Bot mentioned this pull request Jan 11, 2024
Open
markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 11, 2024

bedevere-bot commented Jan 11, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit eaadfd0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 11, 2024
markshannon mentioned this pull request Jan 12, 2024
Merged

markshannon commented Jan 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

All the refleak buildbot failures seem to be from #113944.

The s390x failures seem stack related, so I'll need to fix those.

markshannon changed the title GH-113655: Lower the C recursion limit on Windows GH-113655: Lower the C recursion limit on various platforms Jan 12, 2024

markshannon commented Jan 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390

bedevere-bot commented Jan 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit cc149d8 🤖

The command will test the builders whose names match following regular expression: s390

The builders matched are:

  • s390x Fedora Clang PR
  • s390x RHEL7 LTO PR
  • s390x Fedora Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 PR
  • s390x Debian PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide LTO PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL7 Refleaks PR
  • s390x Fedora PR
  • s390x SLES PR
  • s390x Fedora Rawhide PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora LTO + PGO PR
  • s390x Fedora LTO PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL7 PR

markshannon commented Jan 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390

bedevere-bot commented Jan 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 4a22c7e 🤖

The command will test the builders whose names match following regular expression: s390

The builders matched are:

  • s390x Fedora Clang PR
  • s390x RHEL7 LTO PR
  • s390x Fedora Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 PR
  • s390x Debian PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide LTO PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL7 Refleaks PR
  • s390x Fedora PR
  • s390x SLES PR
  • s390x Fedora Rawhide PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora LTO + PGO PR
  • s390x Fedora LTO PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL7 PR

markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 12, 2024

bedevere-bot commented Jan 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit adae6cf 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 12, 2024

markshannon commented Jan 15, 2024

Copy link
Copy Markdown
Member Author

!buildbot s390

bedevere-bot commented Jan 15, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 1c3e63a 🤖

The command will test the builders whose names match following regular expression: s390

The builders matched are:

  • s390x Fedora Clang PR
  • s390x RHEL7 LTO PR
  • s390x Fedora Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Clang Installed PR
  • s390x RHEL8 Refleaks PR
  • s390x RHEL8 PR
  • s390x Debian PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x Fedora Rawhide LTO PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL7 Refleaks PR
  • s390x Fedora PR
  • s390x SLES PR
  • s390x Fedora Rawhide PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora LTO + PGO PR
  • s390x Fedora LTO PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x RHEL7 PR

encukou commented Jan 16, 2024

Copy link
Copy Markdown
Member

The remaining s390x failure looks unrelated & pre-extisting.

Even if there are more tweaks to be made on s390x, I think it'd be good to get the other platforms green soon.

markshannon merged commit 17b73ab into python:main Jan 16, 2024
markshannon added the needs backport to 3.12 only security fixes label Jan 16, 2024

miss-islington-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 16, 2024

Copy link
Copy Markdown

Sorry, @markshannon, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 17b73ab99ef12f89d41acec7500a244e68b1aaa4 3.12

zooba commented Jan 16, 2024

Copy link
Copy Markdown
Member

The new limit doesn't seem to be low enough for a PGO build: https://dev.azure.com/Python/cpython/_build/results?buildId=147745&view=logs&j=b9a7e24a-1d9b-5019-7703-8e6075dba299&t=e637a57b-456d-5614-0397-39924ec65ef2

Are we best to just skip the test causing it when collecting the profile?

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythonGH-113655: Lower the C recursion limit on various platforms (py…
50b6c26 
…thonGH-113944)
markshannon deleted the lower-c-recursion-limit-for-windows branch February 1, 2024 19:50
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythonGH-113655: Lower the C recursion limit on various platforms (py…
2bf9825 
…thonGH-113944)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythonGH-113655: Lower the C recursion limit on various platforms (py…
fe72ea5 
…thonGH-113944)
hugovk removed the needs backport to 3.12 only security fixes label Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mdboom mdboom approved these changes
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
isidentical Awaiting requested review from isidentical isidentical is a code owner
iritkatriel Awaiting requested review from iritkatriel

Assignees

markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL