Repository navigation
gh-112532: Fix memory block count for free-threaded build - #113995
Merged
corona10 merged 1 commit intoJan 15, 2024
Merged
corona10 merged 1 commit into
corona10 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This fixes `_PyInterpreterState_GetAllocatedBlocks()` and `_Py_GetGlobalAllocatedBlocks()` in the free-threaded builds. The pythongh-113263 change that introduced multiple mimalloc heaps per-thread broke the logic for counting the number of allocated blocks. For subtle reasons, this led to reported reference count leaks in the refleaks buildbots.
Copy link
Copy Markdown
Contributor
Author
|
!buildbot nogil |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 89dfbf1 🤖 The command will test the builders whose names match following regular expression: nogil The builders matched are:
|
Sorry, something went wrong.
corona10
approved these changes
Jan 14, 2024
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
test_socket issue is another issue
See: #112532 (comment)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks @corona10, this is ready to go now. |
Sorry, something went wrong.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…ongh-113995) This fixes `_PyInterpreterState_GetAllocatedBlocks()` and `_Py_GetGlobalAllocatedBlocks()` in the free-threaded builds. The pythongh-113263 change that introduced multiple mimalloc heaps per-thread broke the logic for counting the number of allocated blocks. For subtle reasons, this led to reported reference count leaks in the refleaks buildbots.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ongh-113995) This fixes `_PyInterpreterState_GetAllocatedBlocks()` and `_Py_GetGlobalAllocatedBlocks()` in the free-threaded builds. The pythongh-113263 change that introduced multiple mimalloc heaps per-thread broke the logic for counting the number of allocated blocks. For subtle reasons, this led to reported reference count leaks in the refleaks buildbots.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ongh-113995) This fixes `_PyInterpreterState_GetAllocatedBlocks()` and `_Py_GetGlobalAllocatedBlocks()` in the free-threaded builds. The pythongh-113263 change that introduced multiple mimalloc heaps per-thread broke the logic for counting the number of allocated blocks. For subtle reasons, this led to reported reference count leaks in the refleaks buildbots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes _PyInterpreterState_GetAllocatedBlocks() and _Py_GetGlobalAllocatedBlocks() in the free-threaded builds. The gh-113263 change, which introduced multiple mimalloc heaps per-thread, broke the logic for counting the number of allocated blocks. For subtle reasons, this led to reported reference count leaks in the refleaks buildbots.