GH-78988: Document pathlib.Path.glob() exception propagation. - #114036
Merged
barneygale merged 2 commits intoJan 16, 2024
Merged
GH-78988: Document pathlib.Path.glob() exception propagation.#114036barneygale merged 2 commits into
barneygale merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others.
AA-Turner
approved these changes
Jan 13, 2024
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Probably doesn't need a NEWS, though it also doesn't hurt!
A
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you Adam |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @barneygale, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker 7092b3f1319269accf4c02f08256d51f111b9ca3 3.12 |
Sorry, something went wrong.
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jan 16, 2024
…python#114036) We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others. (cherry picked from commit 7092b3f)
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Jan 16, 2024
…gation. (pythonGH-114036) We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others.. (cherry picked from commit 7092b3f) Co-authored-by: Barney Gale <barney.gale@gmail.com>
Copy link
Copy Markdown
|
GH-114154 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…python#114036) We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…python#114036) We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…python#114036) We propagate the `OSError` from the `is_dir()` call on the top-level directory, and suppress all others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We propagate any OSError from the is_dir() call on the top-level directory, and suppress all others.