FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-114050: Fix crash when more than two arguments are passed to int() by kcatss · Pull Request #114067 · python/cpython · GitHub

/ cpython Public

gh-114050: Fix crash when more than two arguments are passed to int() - #114067

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
kcatss:longobject_typo
Jan 18, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-114050: Fix crash when more than two arguments are passed to int()#114067
serhiy-storchaka merged 2 commits into
python:mainfrom
kcatss:longobject_typo

Conversation

kcatss commented Jan 14, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Remove the typo in the format string, as it is unnecessary

issue : #114050

ghost commented Jan 14, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Jan 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Jan 14, 2024
Closed

AA-Turner commented Jan 15, 2024

Copy link
Copy Markdown
Member

Can you add a test and a blurb entry?

A

hauntsaninja reviewed Jan 15, 2024
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the find! :-)

serhiy-storchaka approved these changes Jan 15, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka commented Jan 15, 2024

Copy link
Copy Markdown
Member

A good place for test: in Lib/test/test_int.py, just after self.assertRaises(TypeError, int, 1, 12). But use valid first two args.

Eclips4 commented Jan 17, 2024

Copy link
Copy Markdown
Member

To help this move forward I added a test case and NEWS entry.

serhiy-storchaka changed the title gh-114050: Remove typo format string in longobject gh-114050: Fix crash when more than two arguments are passed to int() Jan 18, 2024
serhiy-storchaka merged commit a571a2f into python:main Jan 18, 2024
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-114050: Fix crash when more than two arguments are passed to…
8f8613e 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-114050: Fix crash when more than two arguments are passed to…
fd69fae 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-114050: Fix crash when more than two arguments are passed to…
f2d4a09 
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
skirpichev skirpichev approved these changes
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL