FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113655: Skip test_lru_recursion during PGO runs to avoid C stack exhaustion by zooba · Pull Request #114148 · python/cpython · GitHub

/ cpython Public

gh-113655: Skip test_lru_recursion during PGO runs to avoid C stack exhaustion - #114148

Merged
zooba merged 4 commits into
python:mainfrom
zooba:gh-113655
Jan 16, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-113655: Skip test_lru_recursion during PGO runs to avoid C stack exhaustion#114148
zooba merged 4 commits into
python:mainfrom
zooba:gh-113655

Conversation

zooba commented Jan 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

zooba requested a review from markshannon January 16, 2024 19:35
zooba requested a review from rhettinger as a code owner January 16, 2024 19:35
bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jan 16, 2024
bedevere-app Bot mentioned this pull request Jan 16, 2024
Open
ambv reviewed Jan 16, 2024
View reviewed changes
Comment thread Lib/test/test_functools.py Outdated
zooba requested a review from a team as a code owner January 16, 2024 20:35

zooba commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

I'm confident in this hack, but I don't really want to permanently require an extra MB for every thread. #113655 should stay open until we can properly handle/prevent native stack overflows.

zooba merged commit 2e672f7 into python:main Jan 16, 2024
zooba deleted the gh-113655 branch January 16, 2024 22:02
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-113655: Increase default stack size for PGO builds to avoid …
3a3e5a7 
…C stack exhaustion (pythonGH-114148)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-113655: Increase default stack size for PGO builds to avoid …
3f48472 
…C stack exhaustion (pythonGH-114148)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-113655: Increase default stack size for PGO builds to avoid …
6ceec38 
…C stack exhaustion (pythonGH-114148)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
markshannon Awaiting requested review from markshannon
rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

release-blocker skip news tests Tests in the Lib/test dir

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL