gh-112075: Adapt more dict methods to Argument Clinic - #114256
Merged
DinoV merged 13 commits intoJan 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
methane
reviewed
Jan 19, 2024
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
DinoV
force-pushed
the
nogil_dict
branch
2 times, most recently
from
5e7a200 to
72a78e4
Compare
January 19, 2024 21:02
rhettinger
removed their request for review
January 19, 2024 21:28
methane
reviewed
Jan 23, 2024
Comment thread
Objects/dictobject.c
Outdated
methane
reviewed
Jan 23, 2024
Comment thread
Objects/dictobject.c
Outdated
methane
reviewed
Jan 23, 2024
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Comment thread
Objects/dictobject.c
Outdated
Copy link
Copy Markdown
Contributor
|
Sorry to add remarks on the already amended docstrings, but let's avoid the CI churn of addressing this in another PR :) |
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 23, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with last round of suggestions applied.
Sorry, something went wrong.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks, I've appied them all! |
Sorry, something went wrong.
DinoV
enabled auto-merge (squash)
January 23, 2024 20:59
Copy link
Copy Markdown
Contributor
Regen clinic ;) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@DinoV, next time, can you please clean up the commit message before merging? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Ahh yes, sorry! :( |
Sorry, something went wrong.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…14256) * Move more dict objects to argument clinic * Improve doc strings * More doc string improvements * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> --------- Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…14256) * Move more dict objects to argument clinic * Improve doc strings * More doc string improvements * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> * Update Objects/dictobject.c Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> --------- Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses argument clinic for the remaining dict methods which aren't using it yet. This will allow to use argument clinic's @critical_section consistently where it's appropriate.
Mostly straight forward, the most dramatic thing is that some of the argument clinic names overlap with existing names. Those existing names are just wrapped in public dict API so the functionality just moves into the public API.