FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-114328: tty cbreak mode should not alter ICRNL by gpshead · Pull Request #114335 · python/cpython · GitHub

/ cpython Public

gh-114328: tty cbreak mode should not alter ICRNL - #114335

Merged
gpshead merged 3 commits into
python:mainfrom
gpshead:lineprinters-its-the-70s
Jan 21, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-114328: tty cbreak mode should not alter ICRNL#114335
gpshead merged 3 commits into
python:mainfrom
gpshead:lineprinters-its-the-70s

Conversation

gpshead commented Jan 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.

📚 Documentation preview 📚: https://cpython-previews--114335.org.readthedocs.build/

pythongh-114328: tty cbreak mode should not alter ICRNL.
0302768 
CR -> NL mapping should be inherited in cbreak mode as OSes do not
specify altering it as part of their `stty` cbreak mode definition.
gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.12 only security fixes labels Jan 19, 2024
gpshead self-assigned this Jan 19, 2024
bedevere-app Bot mentioned this pull request Jan 19, 2024
Closed

8vasu commented Jan 20, 2024

Copy link
Copy Markdown
Contributor

@gpshead, please see #114328 (comment)

gpshead marked this pull request as draft January 20, 2024 20:11
gpshead marked this pull request as ready for review January 20, 2024 21:41

gpshead commented Jan 20, 2024

Copy link
Copy Markdown
Member Author

Updated further after conversation on the issue, see the discussion there. This should be ready.

serhiy-storchaka reviewed Jan 20, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If it is considered a bugfix, why versionchanged is needed?

ronaldoussoren approved these changes Jan 21, 2024
View reviewed changes

ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gpshead commented Jan 21, 2024

Copy link
Copy Markdown
Member Author

If it is considered a bugfix, why versionchanged is needed?

It's unclear if it is really needed (we normally don't), but it seems nice for our users to call the known issue out for a while. I'm okay with if these get deleted at a some later date.

gpshead merged commit fd49e22 into python:main Jan 21, 2024

miss-islington-app Bot commented Jan 21, 2024

Copy link
Copy Markdown

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

gpshead deleted the lineprinters-its-the-70s branch January 21, 2024 23:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2024
pythongh-114328: tty cbreak mode should not alter ICRNL (pythonGH-114335
e8b93e0 
)

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
(cherry picked from commit fd49e22)

Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jan 21, 2024

Copy link
Copy Markdown

GH-114410 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 21, 2024
gpshead added a commit that referenced this pull request Jan 21, 2024
[3.12] gh-114328: tty cbreak mode should not alter ICRNL (GH-114335) (#…
33c1907 
…114410)

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
(cherry picked from commit fd49e22)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
pythongh-114328: tty cbreak mode should not alter ICRNL (python#114335)
baa4afe 
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-114328: tty cbreak mode should not alter ICRNL (python#114335)
f421909 
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-114328: tty cbreak mode should not alter ICRNL (python#114335)
0dc3c29 
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
ronaldoussoren ronaldoussoren approved these changes

Assignees

gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL