| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
apparently test_embed.py runs this code?
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
Ok, looks like it was used recently in #110769 by @ambv I propose to:
|
Sorry, something went wrong.
|
I am now using another file instead of reperf, it is already used in test_embed and is useful for this test as well: it prints the information, it has some imports, it does some checks. So, we can remove the unneeded reperf 🎉 |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, but I'd rather not backport the removal.
Sorry, something went wrong.
|
@encukou looks like this PR #113601 influenced the CI. I fixed tests, so now both ./python.exe -m test test_embed and ./python.exe Lib/test/_test_embed_structseq.py pass: » ./python.exe Lib/test/_test_embed_structseq.py .. ---------------------------------------------------------------------- Ran 2 tests in 0.000s OK Tests passed Please, take another look :) |
Sorry, something went wrong.
|
OK. Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Looks like this file was not touched for at least 12 years: https://github.com/python/cpython/commits/main/Lib/test/reperf.py
It does not seem useful. If it is, I can instead move it to Tool/scripts.
Refs #114354