Repository navigation
gh-101100: Fix sphinx warnings in asyncio-task.rst - #114469
Merged
hugovk merged 2 commits intoJan 24, 2024
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sobolevn
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
January 23, 2024 08:54
Comment thread
Doc/library/asyncio-task.rst
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk
approved these changes
Jan 23, 2024
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Jan 23, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
The drawback is that it renders the module name together with the constant name. But I think that it is not a big deal here. It may be a problem for longer names.
Sorry, something went wrong.
gvanrossum
approved these changes
Jan 23, 2024
willingc
approved these changes
Jan 24, 2024
Copy link
Copy Markdown
|
Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker 1e4f00ebd8db44a031b61eed0803b4c3d731aed7 3.12 |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 24, 2024
Copy link
Copy Markdown
|
GH-114518 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Jan 24, 2024
…thonGH-114469) (cherry picked from commit 1e4f00e) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-114519 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
hugovk
pushed a commit
that referenced
this pull request
Jan 24, 2024
… (#114518) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Jan 24, 2024
…thonGH-114469) (cherry picked from commit 1e4f00e) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk
added a commit
that referenced
this pull request
Jan 24, 2024
… (#114519) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…4469) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…4469) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be:
📚 Documentation preview 📚: https://cpython-previews--114469.org.readthedocs.build/