FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91602: Add iterdump() support for filtering database objects. by felixxm · Pull Request #114501 · python/cpython · GitHub

/ cpython Public

gh-91602: Add iterdump() support for filtering database objects. - #114501

Merged
erlend-aasland merged 14 commits into
python:mainfrom
felixxm:issue-91602
Feb 6, 2024
ConversationCommits (14)ChecksFiles changed
Merged

gh-91602: Add iterdump() support for filtering database objects.#114501
erlend-aasland merged 14 commits into
python:mainfrom
felixxm:issue-91602

Conversation

felixxm commented Jan 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Docs changes.
  • More tests.
  • Release notes.

bedevere-app Bot mentioned this pull request Jan 23, 2024
Closed
erlend-aasland reviewed Jan 23, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland reviewed Jan 23, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated

erlend-aasland commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

felixxm commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

erlend-aasland commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

Yeah, that's strange; I'd rebase onto main and make regen-all again 😄

erlend-aasland commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

BTW, can you please use git pull --noff main when aligning with main, instead of force pushing? :)

erlend-aasland reviewed Jan 24, 2024
View reviewed changes
Comment thread Lib/sqlite3/dump.py Outdated

felixxm commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for all your help, much appreciated. I will work on tests and docs later today.

erlend-aasland reviewed Jan 24, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland reviewed Jan 24, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland reviewed Jan 24, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated
felixxm changed the title [WIP] gh-91602: Add iterdump() support for filtering database objects. gh-91602: Add iterdump() support for filtering database objects. Jan 24, 2024
felixxm marked this pull request as ready for review January 24, 2024 19:52
felixxm requested a review from berkerpeksag as a code owner January 24, 2024 19:52

felixxm commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Now it's ready for review 🎉

erlend-aasland reviewed Jan 24, 2024
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated

erlend-aasland commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

felixxm commented Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

🍿

erlend-aasland reviewed Jan 25, 2024
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The refcout refactoring in 8cf51d4 is superb; I was just about to suggest it 🚀. I left a small comment regarding how we do the vector call.

When doing changes that affect reference counting, I normally do a refleak test locally:

$ ./python.exe -m test -R : test_sqlite3

Comment thread Modules/_sqlite/connection.c Outdated
erlend-aasland reviewed Jan 25, 2024
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

After this final change, we should be ready to land.

Comment thread Modules/_sqlite/connection.c Outdated

felixxm commented Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

@erlend-aasland Thanks for all your help 🎁

erlend-aasland reviewed Jan 26, 2024
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Now for the docs; I left some comments :)

Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2024-01-24-20-51-49.gh-issue-91602.8fOH8l.rst Outdated

erlend-aasland commented Feb 3, 2024

Copy link
Copy Markdown
Contributor

!buildbot .refleak.

bedevere-bot commented Feb 3, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e314153 🤖

The command will test the builders whose names match following regular expression: .*refleak.*

The builders matched are:

  • aarch64 RHEL8 Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • aarch64 Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • s390x Fedora Refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE RHEL7 Refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • s390x RHEL7 Refleaks PR
  • AMD64 RHEL7 Refleaks PR

erlend-aasland commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

The buildbot/s390x Fedora Rawhide Refleaks PR buildbot failure is unrelated to this PR.

erlend-aasland merged commit 1a10437 into python:main Feb 6, 2024

erlend-aasland commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

Thanks a lot, @felixxm!

felixxm deleted the issue-91602 branch February 6, 2024 12:05
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
pythongh-91602: Add iterdump() support for filtering database objects (…
a973b4b 
…python#114501)

Add optional 'filter' parameter to iterdump() that allows a "LIKE"
pattern for filtering database objects to dump.

Co-authored-by: Erlend E. Aasland <erlend@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL