gh-107901: compiler replaces POP_BLOCK instruction by NOPs before optimisations - #114530
Merged
iritkatriel merged 9 commits intoJan 25, 2024
Merged
iritkatriel merged 9 commits into
iritkatriel merged 9 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
marked this pull request as draft
January 24, 2024 19:37
Copy link
Copy Markdown
Member
Author
|
Converted to draft - I think we should merged #114535 and then this one becomes simpler. |
Sorry, something went wrong.
iritkatriel
marked this pull request as ready for review
January 25, 2024 13:58
markshannon
reviewed
Jan 25, 2024
Comment thread
Python/flowgraph.c
Outdated
iritkatriel
commented
Jan 25, 2024
Comment thread
Python/flowgraph.c
Outdated
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The POP_BLOCK are not needed once the exception handlers are attached to each instruction, so we can replace them by NOPs before optimisation. (The block push instruction are still needed for reachability analysis).