FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-112075: Dictionary global version counter should use atomic increments by DinoV · Pull Request #114568 · python/cpython · GitHub

/ cpython Public

gh-112075: Dictionary global version counter should use atomic increments - #114568

Merged
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_dict_atomic_version
Jan 29, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-112075: Dictionary global version counter should use atomic increments#114568
DinoV merged 1 commit into
python:mainfrom
DinoV:nogil_dict_atomic_version

Conversation

DinoV commented Jan 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Dictionary global version counter should use atomic increments on free-threaded builds

bedevere-app Bot mentioned this pull request Jan 25, 2024
Closed
DinoV marked this pull request as ready for review January 25, 2024 20:42
colesbury approved these changes Jan 25, 2024
View reviewed changes

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Include/internal/pycore_dict.h

#ifdef Py_GIL_DISABLED
#define DICT_NEXT_VERSION(INTERP) \
(_Py_atomic_add_uint64(&(INTERP)->dict_state.global_version, DICT_VERSION_INCREMENT) + DICT_VERSION_INCREMENT)

colesbury Jan 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is fine for now, especially in the interest of getting to the point where we can run the test suite with the GIL disabled, but we will want to avoid contention on the global version counter.

The strategy in nogil and nogil-3.12 was to reserve something like the next 256 versions (atomically) and then serve the next version requests from thread-local state.

colesbury Jan 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For reference: https://github.com/colesbury/nogil-3.12/blob/cedde4f5ec3759ad723c89d44738776f362df564/Include/internal/pycore_dict.h#L169-L177

DinoV Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, nice!

DinoV merged commit 0cd9bac into python:main Jan 29, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-112075: Dictionary global version counter should use atomic …
8603341 
…increments (python#114568)

Dictionary global version counter should use atomic increments
DinoV deleted the nogil_dict_atomic_version branch May 31, 2024 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
corona10 corona10 approved these changes
markshannon Awaiting requested review from markshannon
methane Awaiting requested review from methane

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL