FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103323: Remove current_fast_get() unused parameter by vstinner · Pull Request #114593 · python/cpython · GitHub

/ cpython Public

gh-103323: Remove current_fast_get() unused parameter - #114593

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:current_fast_get
Jan 30, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-103323: Remove current_fast_get() unused parameter#114593
vstinner merged 1 commit into
python:mainfrom
vstinner:current_fast_get

Conversation

vstinner commented Jan 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.

pythongh-103323: Remove current_fast_get() unused parameter
ddce5a1 
The current_fast_get() static inline function doesn't use its
'runtime' parameter, so just remove it.
bedevere-app Bot mentioned this pull request Jan 26, 2024
Closed

vstinner commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

@ericsnowcurrently @colesbury @corona10: Would you mind to review this change?

The change commit f8abfa3 modified current_fast_get(). Before the Python Thread State was retrieved from runtime, but it's no longer the case.

ericsnowcurrently approved these changes Jan 26, 2024
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

IIRC, the main reason I left the parameter was to reduce churn. After that I didn't see any harm in leaving the parameter. That said, I'm not opposed to dropping it.

colesbury approved these changes Jan 26, 2024
View reviewed changes

colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks more straightforward to me too

corona10 approved these changes Jan 26, 2024
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

vstinner merged commit 58f883b into python:main Jan 30, 2024
vstinner deleted the current_fast_get branch January 30, 2024 10:48

vstinner commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-103323: Remove current_fast_get() unused parameter (python#1…
b81e357 
…14593)

The current_fast_get() static inline function doesn't use its
'runtime' parameter, so just remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

colesbury colesbury approved these changes
ericsnowcurrently ericsnowcurrently approved these changes
corona10 corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL