FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix `c-api/file.rst` indexes by sobolevn · Pull Request #114608 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Fix c-api/file.rst indexes - #114608

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
sobolevn:issue-114546
Jan 27, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix c-api/file.rst indexes#114608
serhiy-storchaka merged 2 commits into
python:mainfrom
sobolevn:issue-114546

Conversation

sobolevn commented Jan 26, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

It is now:

Fixes #114546

📚 Documentation preview 📚: https://cpython-previews--114608.org.readthedocs.build/

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 26, 2024
serhiy-storchaka reviewed Jan 26, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can also use .. c:namespace:: NULL.

sobolevn commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

Which one would you prefer: the current or .. c:namespace:: NULL?

serhiy-storchaka commented Jan 26, 2024

Copy link
Copy Markdown
Member

What do you prefer? I slightly prefer your initial layout, i.e. documenting Py_OpenCodeHookFunction "inside" the documentation for PyFile_SetOpenCodeHook, since the former is only used in the latter.

sobolevn commented Jan 26, 2024

Copy link
Copy Markdown
Member Author

After comparing both, I am returning the initial layout, it is much easier to read 👍

serhiy-storchaka approved these changes Jan 27, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 27, 2024
serhiy-storchaka merged commit 23fb9f0 into python:main Jan 27, 2024

miss-islington-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 23fb9f0777b054526b3b32f58e60b2a03132bf45 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2024
Fix c-api/file.rst indexes (pythonGH-114608)
87e2a1e 
(cherry picked from commit 23fb9f0)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Jan 27, 2024

Copy link
Copy Markdown

GH-114639 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 27, 2024
serhiy-storchaka pushed a commit that referenced this pull request Jan 27, 2024
[3.11] Fix c-api/file.rst indexes (GH-114608) (GH-114639)
b323d99 
(cherry picked from commit 23fb9f0)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Fix c-api/file.rst indexes (pythonGH-114608)
2bf6a83
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Fix c-api/file.rst indexes (pythonGH-114608)
39e669a

serhiy-storchaka commented Sep 29, 2024

Copy link
Copy Markdown
Member

@sobolevn, this was backported to 3.11, but not to 3.12. Do you mind to make a backport?

sobolevn commented Sep 29, 2024

Copy link
Copy Markdown
Member Author

Will do

sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 30, 2024
[3.12] Fix c-api/file.rst indexes (pythonGH-114608)
c054de0 
(cherry picked from commit 23fb9f0)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Sep 30, 2024

Copy link
Copy Markdown

GH-124786 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 30, 2024
sobolevn added a commit that referenced this pull request Sep 30, 2024
[3.12] Fix c-api/file.rst indexes (GH-114608) (#124786)
f9cce95 
(cherry picked from commit 23fb9f0)
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
hugovk Awaiting requested review from hugovk

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL