FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-114875: Add `getgrent` as a prerequisite for building the `grp` module by mhsmith · Pull Request #114876 · python/cpython · GitHub

/ cpython Public

gh-114875: Add getgrent as a prerequisite for building the grp module - #114876

Merged
erlend-aasland merged 3 commits into
python:mainfrom
mhsmith:grp-getgrent
Feb 2, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-114875: Add getgrent as a prerequisite for building the grp module#114876
erlend-aasland merged 3 commits into
python:mainfrom
mhsmith:grp-getgrent

Conversation

mhsmith commented Feb 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This allows the module to be correctly skipped on older versions of Android which don't have getgrent and related functions:

checking for getgrent... no
checking for getgrgid... yes
checking for getgrgid_r... no
[...]
checking for stdlib extension module grp... missing

bedevere-app Bot mentioned this pull request Feb 1, 2024
Closed
erlend-aasland reviewed Feb 1, 2024
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Comment thread Misc/NEWS.d/next/Build/2024-02-01-20-08-11.gh-issue-114875.x_2iZ9.rst Outdated
Comment thread configure.ac Outdated
mhsmith and others added 2 commits February 2, 2024 19:43
Apply suggestions from code review
bb1fe58 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Autoreconf
9cf79f3

mhsmith commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

Thanks; suggestions all applied.

erlend-aasland merged commit f35c7c0 into python:main Feb 2, 2024

erlend-aasland commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Thanks again :)

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-114875: Require getgrent for building the grp extension modu…
b5273ef 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
pythongh-114875: Require getgrent for building the grp extension modu…
73b7e69 
…le (python#114876)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
mhsmith deleted the grp-getgrent branch February 16, 2024 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grp module attempts to build even if getgrent family of functions are unavailable

2 participants

Back | FazBrowse Home | New Git URL