Repository navigation
gh-114949: fix signature in the type.__prepare__() doc string - #114950
Closed
skirpichev wants to merge 3 commits into
Closed
skirpichev wants to merge 3 commits into
skirpichev wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Author
|
Probably could skip news. Not sure if it worth to add also a regression test. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
What is the problem this solves? On main I see: >>> inspect.signature(type.__prepare__) <Signature (name, bases, /, **kwds)> Which seems correct. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I believe the problem described by #114949 (comment) was solved by commit 1d75ef6b6186619081c166b21c71c15b4f98beb8
Author: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon Nov 13 09:13:49 2023 +0200
gh-111999: Add signatures and improve docstrings for builtins (GH-112000)
Lib/test/test_inspect/test_inspect.py | 11 +++++---
Objects/boolobject.c | 5 ++--
Objects/descrobject.c | 3 +++
Objects/funcobject.c | 6 +++--
Objects/setobject.c | 48 +++++++++++++++++++++++------------
Objects/typeobject.c | 6 +++--
Objects/unicodeobject.c | 12 +++++----
Python/bltinmodule.c | 22 +++++++++-------
8 files changed, 74 insertions(+), 39 deletions(-)
On Python 3.12, and on the main branch prior to 1d75ef6, we see this behaviour: ~/dev/cpython (d0058cbd1cd) % ./python.exe -c "import inspect; print(inspect.signature(type.__prepare__))"
Traceback (most recent call last):
File "<string>", line 1, in <module>
import inspect; print(inspect.signature(type.__prepare__))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/alexw/dev/cpython/Lib/inspect.py", line 3366, in signature
return Signature.from_callable(obj, follow_wrapped=follow_wrapped,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/alexw/dev/cpython/Lib/inspect.py", line 3108, in from_callable
return _signature_from_callable(obj, sigcls=cls,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/alexw/dev/cpython/Lib/inspect.py", line 2599, in _signature_from_callable
return _signature_from_builtin(sigcls, obj,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/alexw/dev/cpython/Lib/inspect.py", line 2398, in _signature_from_builtin
raise ValueError("no signature found for builtin {!r}".format(func))
ValueError: no signature found for builtin <built-in method __prepare__ of type object at 0x100eae0e0>On 1d75ef6 and subsequent commits, we see this: ~/dev/cpython (1d75ef6b618) % ./python.exe -c "import inspect; print(inspect.signature(type.__prepare__))" Although I see you were a reviewer for #112000, @skirpichev, and you filed this PR after that one was merged. So maybe that isn't actually the problem you're describing in #114949 (comment)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Indeed, now fixed in the main. I'll close this (and issue). Note, however, that $ git grep '$cls' Objects Modules/
Objects/typeobject.c: PyDoc_STR("__prepare__($cls, name, bases, /, **kwds)\n"
$ git grep '$type' Objects/ Modules/
Objects/clinic/bytearrayobject.c.h:"fromhex($type, string, /)\n"
Objects/clinic/bytesobject.c.h:"fromhex($type, string, /)\n"
Objects/clinic/complexobject.c.h:"from_number($type, number, /)\n"
Objects/clinic/dictobject.c.h:"fromkeys($type, iterable, value=None, /)\n"
Objects/clinic/floatobject.c.h:"fromhex($type, string, /)\n"
Objects/clinic/floatobject.c.h:"from_number($type, number, /)\n"
Objects/clinic/floatobject.c.h:"__getformat__($type, typestr, /)\n"
Objects/clinic/longobject.c.h:"from_bytes($type, /, bytes, byteorder=\'big\', *, signed=False)\n"
Objects/clinic/memoryobject.c.h:"_from_flags($type, /, object, flags)\n"
Objects/clinic/odictobject.c.h:"fromkeys($type, /, iterable, value=None)\n"
Objects/typeobject.c: return "($type, /)";
Objects/typeobject.c: return "($type, object, /)";
Objects/typeobject.c: PyDoc_STR("__new__($type, *args, **kwargs)\n--\n\n"
Modules/_decimal/docstrings.h:"from_float($type, f, /)\n--\n\n\
Modules/_multiprocessing/clinic/semaphore.c.h:"_rebuild($type, handle, kind, maxvalue, name, /)\n"
Modules/_testcapi/docstring.c: "classmeth($type, /, a, b=<x>)\n"
Modules/clinic/_datetimemodule.c.h:"fromtimestamp($type, timestamp, /)\n"
Modules/clinic/_datetimemodule.c.h:"now($type, /, tz=None)\n"
Modules/clinic/_zoneinfo.c.h:"from_file($type, file_obj, /, key=None)\n"
Modules/clinic/_zoneinfo.c.h:"no_cache($type, /, key)\n"
Modules/clinic/_zoneinfo.c.h:"clear_cache($type, /, *, only_keys=None)\n"
Modules/clinic/_zoneinfo.c.h:"_unpickle($type, key, from_cache, /)\n"
Modules/clinic/itertoolsmodule.c.h:"from_iterable($type, iterable, /)\n"
Modules/clinic/selectmodule.c.h:"fromfd($type, fd, /)\n"
Modules/clinic/selectmodule.c.h:"fromfd($type, fd, /)\n"
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.