FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix dangling references in pickle.rst by smontanaro · Pull Request #114972 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix dangling references in pickle.rst - #114972

Merged
AlexWaygood merged 3 commits into
python:mainfrom
smontanaro:patch-10
Feb 4, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-101100: Fix dangling references in pickle.rst#114972
AlexWaygood merged 3 commits into
python:mainfrom
smontanaro:patch-10

Conversation

smontanaro commented Feb 3, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Fairly straightforward. Oddly enough, I found no canonical definition of append or extend methods, so I just. suppressed those links.

📚 Documentation preview 📚: https://cpython-previews--114972.org.readthedocs.build/

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 3, 2024
bedevere-app Bot mentioned this pull request Feb 3, 2024
Closed
AlexWaygood reviewed Feb 4, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Two small suggestions:

Comment thread Doc/library/pickle.rst Outdated
Comment thread Doc/library/pickle.rst Outdated
Apply suggestions from code review
9583171 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changes Feb 4, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, looks great! However, I'm unable to merge this PR (the "merge" button is physically unavailable to me right now 🙂) until the CI failure is fixed as part of this PR:

Congratulations! You improved:

Doc/library/pickle.rst

Please remove from Doc/tools/.nitignore

Error: Process completed with exit code 255.

Could you remove that line from Doc/tools/.nitignore?

smontanaro commented Feb 4, 2024

Copy link
Copy Markdown
Contributor Author

Could you remove that line from Doc/tools/.nitignore?

Should be good to go.

AlexWaygood commented Feb 4, 2024

Copy link
Copy Markdown
Member

Thanks!

AlexWaygood merged commit ec69e1d into python:main Feb 4, 2024
AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 4, 2024

miss-islington-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2024
pythongh-101100: Fix dangling references in pickle.rst (pythonGH-114972)
ce9d7f1 
(cherry picked from commit ec69e1d)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

miss-islington-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

Sorry, @smontanaro and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ec69e1d0ddc9906e0fb755a5234aeabdc96450ab 3.12

bedevere-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

GH-114992 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 4, 2024
smontanaro deleted the patch-10 branch February 4, 2024 14:26
AlexWaygood added a commit that referenced this pull request Feb 4, 2024
[3.11] gh-101100: Fix dangling references in pickle.rst (GH-114972) (#…
55e5ae7 
…114992)

gh-101100: Fix dangling references in pickle.rst (GH-114972)
(cherry picked from commit ec69e1d)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
smontanaro added a commit to smontanaro/cpython that referenced this pull request Feb 4, 2024
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
bc59045 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit ec69e1d)

bedevere-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

GH-114999 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot commented Feb 4, 2024

Copy link
Copy Markdown

GH-114999 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 4, 2024
AlexWaygood added a commit that referenced this pull request Feb 4, 2024
[3.12] gh-101100: Fix dangling references in pickle.rst (#114972) (#1…
709a293 
…14999)

gh-101100: Fix dangling references in pickle.rst (#114972)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit ec69e1d)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
bf7482d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
pythongh-101100: Fix dangling references in pickle.rst (python#114972)
0513406 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

AlexWaygood

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL