FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix extending.rst by smontanaro · Pull Request #114981 · python/cpython · GitHub

Repository navigation

gh-101100: Fix extending.rst - #114981

Closed
smontanaro wants to merge 0 commit into
python:mainfrom
smontanaro:main
Closed

smontanaro wants to merge 0 commit into
python:mainfrom
smontanaro:main

Conversation

smontanaro commented Feb 4, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Wrong data type for PyImport_Inittab


📚 Documentation preview 📚: https://cpython-previews--114981.org.readthedocs.build/

Copy link
Copy Markdown
Contributor Author

I did nothing. Why does it think I did something? @hugovk or @AlexWaygood can you explain?

Copy link
Copy Markdown
Member

It looks like you made this PR directly from your main branch. That's generally a bad idea — it can cause strange things like this to happen :)

I suggest always making a new branch for each PR you create on github

Copy link
Copy Markdown
Contributor Author

What I've been doing with these small edits is to edit the file on python/cpython in GitHub. I guess I accidentally edited this one on smontanaro/cpython.

I find the whole manually create a new branch for each little change to be annoying, so for these small edits I've resorted to editing through the GitHub web interface. (I actually edit locally, remake html or htmllive, then check the result and paste the edited file into the web interface.)

Copy link
Copy Markdown
Member

Specifically, it looks like you might have force-pushed to the main branch of your CPython clone to get it in sync with CPython's main branch. That then meant that there were 0 changes between your main branch and CPython's main branch; so, since this is a PR asking for changes from your main branch to be merged into CPython's main branch, github automatically closed the PR.

Copy link
Copy Markdown
Contributor Author

Okay, I can buy that. I do remember accidentally committing some small doc change, then later issuing a git revert command.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL