| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
It seems like this PR also includes all the changes from your unrelated other PR: Was that intentional? Perhaps you had your branch for that PR checked out, instead of your main branch, before creating this branch locally? That would mean that this PR branch would "branch off" from that branch, instead of from your main branch :) |
Sorry, something went wrong.
|
sigh I just branched from my main. Apologies. Not sure how to proceed at this point. |
Sorry, something went wrong.
I fixed things up for you by pushing to your branch (you'll have to git pull locally to update your local clone and make further updates locally 🙂). I don't work much with the C API, so I don't have strong opinions on the C API docs -- it'd be great if @serhiy-storchaka might be able to take a look at this one |
Sorry, something went wrong.
Sorry, something went wrong.
|
Oh, maybe it's complaining about the section below the message, not above it. |
Sorry, something went wrong.
Sorry, something went wrong.
Too late. I will revert it if it's a deal breaker, but I see no reason that it needs to actually be documented in Python's documentation. |
Sorry, something went wrong.
I don't think it's a deal-breaker :) |
Sorry, something went wrong.
There was a problem hiding this comment.
It would be nice to add the Py_DEBUG macro to the index.
Add the .. macro:: Py_DEBUG directive, look what index is generated for it, and add the same index with the .. index:: directive.
Sorry, something went wrong.
…ther references and an index entry.
|
@serhiy-storchaka I added an explicit :c:macro: PyDEBUG target in intro.rst and referenced it from test.rst. This generates both an anchor for other references and an index entry. While I was at it, I simplified the text in test.rst. Since it already refers the reader to the debug build details in using/configure.rst, I saw no reason to actually duplicate the configure command example here. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great!
Sorry, something went wrong.
|
Thanks @smontanaro for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
|
Sorry, @smontanaro and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict. cherry_picker d0322fdf2c1a7292a43959fe5a572d783b88a1c4 3.11 |
Sorry, something went wrong.
|
GH-115135 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
|
GH-115141 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Per conversation with @AlexWaygood, here is a small proposed fix to a few broken Py_DEBUG links. My suggestion was to reference the _debug-build anchor. Aside from that, all this does so far is suppress dangling Py_DEBUG references in the same paragraphs where the _debug-build anchor is referenced.
📚 Documentation preview 📚: https://cpython-previews--115003.org.readthedocs.build/