gh-97928: Partially restore the behavior of tkinter.Text.count() by default - #115031
Merged
serhiy-storchaka merged 3 commits intoFeb 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
force-pushed
the
tkinter-text-count-return_ints
branch
from
9f6e1db to
26aea45
Compare
February 5, 2024 17:00
…) by default By default, it preserves an inconsistent behavior of older Python versions: packs the count into a 1-tuple if only one or none options are specified (including 'update'), returns None instead of 0. Except that setting wantobjects to 0 no longer affects the result. Add a new parameter return_ints: specifying return_ints=True makes Text.count() always returning the single count as an integer insteaf of a 1-tuple or None.
serhiy-storchaka
force-pushed
the
tkinter-text-count-return_ints
branch
from
26aea45 to
e44adec
Compare
February 5, 2024 17:01
serhiy-storchaka
commented
Feb 5, 2024
Comment thread
Doc/whatsnew/3.13.rst
Outdated
terryjreedy
reviewed
Feb 5, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks ok with an optional comment deletion and two questions. EDIT Sufficiently answered.
The added tests look correct.
Sorry, something went wrong.
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…) by default (pythonGH-115031) By default, it preserves an inconsistent behavior of older Python versions: packs the count into a 1-tuple if only one or none options are specified (including 'update'), returns None instead of 0. Except that setting wantobjects to 0 no longer affects the result. Add a new parameter return_ints: specifying return_ints=True makes Text.count() always returning the single count as an integer instead of a 1-tuple or None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, it preserves an inconsistent behavior of older Python versions: packs the count into a 1-tuple if only one or none options are specified (including 'update').
Except that setting wantobjects to 0 no longer affects the result.
Add a new parameter return_ints: specifying return_ints=True makes Text.count() returning the single count as an integer.
📚 Documentation preview 📚: https://cpython-previews--115031.org.readthedocs.build/