Repository navigation
gh-114271: Make PyInterpreterState.threads.count thread-safe in free-threaded builds - #115093
Merged
ericsnowcurrently merged 1 commit intoFeb 12, 2024
Merged
ericsnowcurrently merged 1 commit into
ericsnowcurrently merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…builds Use atomics
mpage
force-pushed
the
gh-114271-threads.count
branch
from
b22b2f0 to
7274538
Compare
February 6, 2024 17:37
mpage
marked this pull request as ready for review
February 6, 2024 19:12
Copy link
Copy Markdown
Contributor
Author
|
@colesbury - Can you add the "skip news" label to this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@colesbury - Would you take a look at this, please? |
Sorry, something went wrong.
colesbury
approved these changes
Feb 12, 2024
colesbury
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ericsnowcurrently
approved these changes
Feb 12, 2024
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…in free-threaded builds (pythongh-115093) Use atomics to mutate PyInterpreterState.threads.count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use atomics to mutate PyInterpreterState.threads.count