GH-113710: Fix updating of dict version tag and add watched dict stats - #115221
GH-113710: Fix updating of dict version tag and add watched dict stats#115221markshannon merged 8 commits into
Conversation
Sorry, something went wrong.
| uint64_t func_modification; | ||
| /* Modifying a dict that is being watched */ | ||
| uint64_t watched_dict_modification; | ||
| uint64_t watched_globals_modification; |
There was a problem hiding this comment.
How do these new stats relate to the existing builtin_dict one?
Sorry, something went wrong.
There was a problem hiding this comment.
They only apply to any watched dict, and watched module globals respectively.
Whereas the builtin dict count tracks any modification to the builtins, which are always watched
In theory watched_globals_modification + builtin_dict == watched_dict_modification
Although, as soon as we start watching any other dicts that will no longer be true.
Sorry, something went wrong.
There was a problem hiding this comment.
That makes sense, thanks.
Sorry, something went wrong.
|
The stats look good ~800 dict watchers fired instead of 8 million. |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
So I take it PyDict_EVENT_CLONED is no longer special?
Sorry, something went wrong.
It never was, it was (and still is) misnamed. |
Sorry, something went wrong.
Fixes a regression introduced by #114592 where mutating a global variable would cause repeated de-optimizations.