Repository navigation
gh-82062: correctly set module for built-in instance methods in inspect.signature() - #115270
Merged
serhiy-storchaka merged 8 commits intoMay 2, 2024
Merged
serhiy-storchaka merged 8 commits into
serhiy-storchaka merged 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… inspect.signature() The ``__module__`` attribute is missing for instance methods in extension modules, so instead we use in this case ``__objclass__.__module__``.
Copy link
Copy Markdown
Member
Author
|
Alternatively, we could set the __module__ attribute for instance methods, see #115232. Right now for built-in instance methods its missing (c.f. pure-python classes): >>> int.to_bytes.__module__
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'method_descriptor' object has no attribute '__module__'. Did you mean: '__reduce__'? |
Sorry, something went wrong.
serhiy-storchaka
self-requested a review
April 30, 2024 09:04
Comment thread
Lib/inspect.py
Outdated
Comment thread
Lib/test/test_capi/test_misc.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Copy link
Copy Markdown
Member
Author
|
@serhiy-storchaka, I hope I did requested changes. |
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
AlexWaygood
reviewed
Apr 30, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
…S6w7.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
serhiy-storchaka
approved these changes
Apr 30, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…sion modules (pythonGH-115270) Now inspect.signature() supports references to the module globals in parameter defaults on methods in extension modules. Previously it was only supported in functions. The workaround was to specify the fully qualified name, including the module name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __module__ attribute is missing for instance methods in extension modules, so instead we use in this case __objclass__.__module__.