gh-114570: Add PythonFinalizationError exception - #115352
Merged
vstinner merged 2 commits intoFeb 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
requested review from
ericsnowcurrently,
gpshead and
iritkatriel
as code owners
February 12, 2024 16:37
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
gpshead
approved these changes
Feb 13, 2024
gpshead
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks!
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Feb 13, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Add PythonFinalizationError exception. This exception derived from RuntimeError is raised when an operation is blocked during the Python finalization. The following functions now raise PythonFinalizationError, instead of RuntimeError: * _thread.start_new_thread() * subprocess.Popen * os.fork() * os.fork1() * os.forkpty() Morever, _winapi.Overlapped finalizer now logs an unraisable PythonFinalizationError, instead of an unraisable RuntimeError.
vstinner
force-pushed
the
python_finalization_error2
branch
from
6d096b9 to
30bd9c9
Compare
February 14, 2024 21:54
Copy link
Copy Markdown
Member
Author
|
PR rebased on main to attempt to fix the macos-13 CI issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Merged. Thanks for the review @gpshead and @serhiy-storchaka. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PythonFinalizationError exception. This exception derived from RuntimeError is raised when an operation is blocked during the Python finalization.
The following functions now raise PythonFinalizationError, instead of RuntimeError:
Morever, _winapi.Overlapped finalizer now logs an unraisable PythonFinalizationError, instead of an unraisable RuntimeError.
📚 Documentation preview 📚: https://cpython-previews--115352.org.readthedocs.build/