FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351) by ambv · Pull Request #115404 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351) - #115404

Merged
ambv merged 1 commit into
python:3.8from
ambv:backport-3fcea41-3.8
Feb 13, 2024
ConversationCommits (1)ChecksFiles changed
Merged

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351)#115404
ambv merged 1 commit into
python:3.8from
ambv:backport-3fcea41-3.8

Conversation

ambv commented Feb 13, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

[3.8] [3.9] pythongh-115349: Pin theme to fix code snippets (pythonGH…
daf72c8 
…-115351)

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
bedevere-app Bot mentioned this pull request Feb 13, 2024
Merged
bedevere-app Bot mentioned this pull request Feb 13, 2024
Closed
hugovk approved these changes Feb 13, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Built locally:

ambv commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

@hugovk I appreciate it but this was about the dark theme, no?

hugovk commented Feb 13, 2024

Copy link
Copy Markdown
Member

Yes, we're pinning to the last version before the dark theme was added.

This the minimal fix, because the dark theme requires Sphinx 3 for proper syntax highlighting, and the 3.8/3.9 docs use Sphinx 2.4.4.

We can look into bumping Sphinx to 3+, but it will likely also require bumping other dependencies, and for security branches I felt it would be easier/safer to pin to an older python-docs-theme.

ambv commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

Ah, got it. Right. Okay then, let's go.

ambv merged commit a21c0c7 into python:3.8 Feb 13, 2024
ambv deleted the backport-3fcea41-3.8 branch February 13, 2024 13:44
hugovk mentioned this pull request Mar 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL