gh-115119: Detect _decimal dependencies using pkg-config - #115406
Merged
erlend-aasland merged 8 commits intoApr 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Only libmpdec 4.0.0 supports pkg-config.
15 tasks
Copy link
Copy Markdown
Contributor
Author
|
Tested on macOS with the following scenarios: $ ./configure && make # Uses CPython vendored mpdecimal
$ ./configure --with-system-libmpdec && make # pkg-config detects Homebrew installed libmpdec 4.0.0
$ LIBMPDEC_CFLAGS="-I$HOME/install" \
LIBMPDEC_LIBS="-L$HOME/install -lm -lmpdec" \
./configure --with-system-libmpdec && make # Build with custom libmpdec 2.5.1For some reason the latter fails, but I suspect it is an issue with my setup. |
Sorry, something went wrong.
erlend-aasland
commented
Mar 30, 2024
Comment thread
Modules/_decimal/_decimal.c
Outdated
erlend-aasland
commented
Mar 30, 2024
Comment thread
Modules/_decimal/_decimal.c
Outdated
rhettinger
removed their request for review
March 30, 2024 19:21
ned-deily
approved these changes
Apr 29, 2024
ned-deily
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks! FWIW, I was able to successfully build and test with mpdecimal 2.5.1 as well as 4.0.0.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks, Ned! I had forgotten about this :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only libmpdec 4.0.0 supports pkg-config.