FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable by erlend-aasland · Pull Request #115449 · python/cpython · GitHub

/ cpython Public

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable - #115449

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:dbm/alt-fix-sqlite3-backend
Feb 14, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115449
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:dbm/alt-fix-sqlite3-backend

Conversation

erlend-aasland commented Feb 14, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Feb 14, 2024
Closed
bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 14, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
AlexWaygood mentioned this pull request Feb 14, 2024
Closed

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

I think I prefer this fix.

AlexWaygood approved these changes Feb 14, 2024
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See my comments in #115448 (comment). This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test. But either is probably fine; no strong preference :)

AlexWaygood commented Feb 14, 2024

Copy link
Copy Markdown
Member

This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test.

You could maybe add a comment noting that the imports need to be in precisely that order

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

You could maybe add a comment noting that the imports need to be in precisely that order

Yes, that seems fair to the future reader.

erlend-aasland commented Feb 14, 2024
View reviewed changes
Comment thread Lib/test/test_dbm_sqlite3.py
Update Lib/test/test_dbm_sqlite3.py
767c8b0 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland enabled auto-merge (squash) February 14, 2024 12:28

erlend-aasland commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the review(s), Alex!

AlexWaygood commented Feb 14, 2024

Copy link
Copy Markdown
Member

No worries!

erlend-aasland mentioned this pull request Feb 14, 2024
Merged

encukou commented Feb 14, 2024

Copy link
Copy Markdown
Member

!buildbot AMD64 RHEL7

bedevere-bot commented Feb 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit d9a099c 🤖

The command will test the builders whose names match following regular expression: AMD64 RHEL7

The builders matched are:

  • AMD64 RHEL7 LTO PR
  • AMD64 RHEL7 PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 LTO + PGO PR

erlend-aasland merged commit 029ec91 into python:main Feb 14, 2024
erlend-aasland deleted the dbm/alt-fix-sqlite3-backend branch February 14, 2024 13:16
erlend-aasland mentioned this pull request Feb 14, 2024
Merged
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
pythongh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable (pyt…
642d5f6 
…hon#115449)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
serhiy-storchaka serhiy-storchaka approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL