FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fails by niklasf · Pull Request #11553 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fails - #11553

Merged
miss-islington merged 1 commit into
python:masterfrom
niklasf:socket-pair-leak-35721
May 20, 2019
ConversationCommits (1)ChecksFiles changed
Merged

bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fails#11553
miss-islington merged 1 commit into
python:masterfrom
niklasf:socket-pair-leak-35721

Conversation

niklasf commented Jan 14, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This slightly expands an existing test case test_popen_error to trigger a ResourceWarning and fixes it.

https://bugs.python.org/issue35721

asvetlov requested changes Jan 16, 2019
View reviewed changes
Comment thread Lib/asyncio/unix_events.py Outdated

asvetlov Jan 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please move the line before open() call.
It saves 1 open file descriptor.
Not a very big deal but why not?

1st1 Jan 16, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure I even understand this code :) What's it for? Why does monkeypatching self._proc.stdin work?

asvetlov Jan 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@1st1 please read a code comment at the begin of the method.
AIX requires to make stdin a socket pair (I love all Unix flavors and their differences).
proc.stdin should be a writable file-like object.
open() creates a file object from write-fd of created socket pair.

It exists in asyncio starting from very old times.

niklasf Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@asvetlov: Good point. I suppose since open(stdin_w.detach(), ...) cannot fail I should have kept the order.

1st1 Jan 16, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@1st1 please read a code comment at the begin of the method.

Yeah, that's what I did first. The comment doesn't explain why we pass the read end of the pipe to Popen initially (I see that we then monkey-patch it to the write end).

It exists in asyncio starting from very old times.

I've no problem with the code or this PR, but I wish that the comment is a bit more elaborate.

asvetlov Jan 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@1st1 you know, I'm bad in comment writing, sorry.
Would you propose exact text?

Comment thread Lib/test/test_asyncio/test_subprocess.py Outdated

bedevere-bot commented Jan 16, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

niklasf force-pushed the socket-pair-leak-35721 branch from 3b43fd0 to e6a1cf3 Compare January 16, 2019 20:33

niklasf commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

bedevere-bot commented Jan 16, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

niklasf force-pushed the socket-pair-leak-35721 branch from e6a1cf3 to e19f742 Compare January 18, 2019 16:31
niklasf mentioned this pull request Jan 18, 2019
Closed
1 task done

niklasf commented May 18, 2019

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to help this move along?

csabella requested a review from asvetlov May 18, 2019 19:38

miss-islington commented May 20, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington merged commit 9932fd9 into python:master May 20, 2019

miss-islington commented May 20, 2019

Copy link
Copy Markdown
Contributor

Thanks @niklasf for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2019
bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fai…
a0cc6ec 
…ls (pythonGH-11553)

This slightly expands an existing test case `test_popen_error` to trigger a `ResourceWarning` and fixes it.

https://bugs.python.org/issue35721
(cherry picked from commit 9932fd9)

Co-authored-by: Niklas Fiekas <niklas.fiekas@backscattering.de>

bedevere-bot commented May 20, 2019

Copy link
Copy Markdown

GH-13439 is a backport of this pull request to the 3.7 branch.

asvetlov commented May 20, 2019

Copy link
Copy Markdown
Contributor

Let's land it.
Thanks!

miss-islington added a commit that referenced this pull request May 20, 2019
bpo-35721: Close socket pair if Popen in _UnixSubprocessTransport fai…
3887932 
…ls (GH-11553)

This slightly expands an existing test case `test_popen_error` to trigger a `ResourceWarning` and fixes it.

https://bugs.python.org/issue35721
(cherry picked from commit 9932fd9)

Co-authored-by: Niklas Fiekas <niklas.fiekas@backscattering.de>

niklasf commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes
1st1 Awaiting requested review from 1st1
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL