Repository navigation
bpo-35746: Fix segfault in ssl's cert parser - #11569
Merged
miss-islington merged 1 commit intoJan 15, 2019
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
reviewed
Jan 15, 2019
Comment thread
Lib/test/test_ssl.py
Outdated
Comment thread
Misc/NEWS.d/next/Security/2019-01-15-18-16-05.bpo-35746.nMSd0j.rst
Outdated
alex
reviewed
Jan 15, 2019
Comment thread
Lib/test/test_ssl.py
Outdated
Comment thread
Misc/NEWS.d/next/Security/2019-01-15-18-16-05.bpo-35746.nMSd0j.rst
Outdated
Comment thread
Lib/test/test_ssl.py
Outdated
Comment thread
Modules/_ssl.c
Outdated
Comment thread
Modules/_ssl.c
Outdated
Comment thread
Modules/_ssl.c
Outdated
tiran
force-pushed
the
bpo-35746-crldp-segfault
branch
2 times, most recently
from
70326d8 to
9b00d25
Compare
January 15, 2019 17:42
CVE-2019-5010, Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-35746-crldp-segfault
branch
from
9b00d25 to
c660deb
Compare
January 15, 2019 17:56
vstinner
approved these changes
Jan 15, 2019
alex
approved these changes
Jan 15, 2019
ned-deily
approved these changes
Jan 15, 2019
ned-deily
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Verified that the new test causes segfaults on 3.7 and 3.6 and that the fix to _ssl.c when cherry-picked to 3.7 and 3.6 prevents those segfaults.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-11572 is a backport of this pull request to the 3.7 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
Copy link
Copy Markdown
|
GH-11573 is a backport of this pull request to the 3.6 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
Copy link
Copy Markdown
|
GH-11574 is a backport of this pull request to the 2.7 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 15, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
miss-islington
added a commit
that referenced
this pull request
Jan 15, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
miss-islington
added a commit
that referenced
this pull request
Jan 15, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
ned-deily
pushed a commit
that referenced
this pull request
Jan 16, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Signed-off-by: Christian Heimes <christian@python.org> https://bugs.python.org/issue35746 (cherry picked from commit a37f524) Co-authored-by: Christian Heimes <christian@python.org>
larryhastings
pushed a commit
that referenced
this pull request
Feb 25, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerability (TALOS-2018-0758) reported by Colin Read and Nicolas Edet of Cisco. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit a37f524)
larryhastings
pushed a commit
that referenced
this pull request
Feb 26, 2019
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerability (TALOS-2018-0758) reported by Colin Read and Nicolas Edet of Cisco. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit a37f524)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL
distribution points with empty DP or URI correctly. A malicious or buggy
certificate can result into segfault.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue35746