gh-115754: Export Py_None, Py_False, Py_True as symbols - #115755
Closed
vstinner wants to merge 2 commits into
Closed
gh-115754: Export Py_None, Py_False, Py_True as symbols#115755vstinner wants to merge 2 commits into
vstinner wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Two more constants to consider: #define Py_Ellipsis (&_Py_EllipsisObject) #define Py_NotImplemented (&_Py_NotImplementedStruct) Update: I completed my PR to also cover these two constants. |
Sorry, something went wrong.
vstinner
force-pushed
the
export_constants
branch
from
5dbd27b to
614df03
Compare
February 21, 2024 10:45
In the limited C API and the stable ABI, implement Py_None, Py_False, Py_True, Py_Ellipsis and Py_NotImplemented constants are symbols.
vstinner
force-pushed
the
export_constants
branch
from
614df03 to
5002f4d
Compare
February 21, 2024 16:20
Copy link
Copy Markdown
Member
Author
|
Counter-proposition: #116572 implement these constants as function calls in the limited C API. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The C API Working Group chose to go with a function call instead: capi-workgroup/decisions#16 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the limited C API and the stable ABI, implement Py_None, Py_False and Py_True constants are symbols.