gh-115773: Add tests to exercise the _Py_DebugOffsets structure - #115774
Merged
pablogsal merged 8 commits intoFeb 28, 2024
Merged
gh-115773: Add tests to exercise the _Py_DebugOffsets structure#115774pablogsal merged 8 commits into
pablogsal merged 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
requested review from
corona10,
ericsnowcurrently and
erlend-aasland
as code owners
February 21, 2024 16:47
pablogsal
force-pushed
the
external_inspection
branch
3 times, most recently
from
7e477c9 to
3583be6
Compare
February 21, 2024 17:18
pablogsal
force-pushed
the
external_inspection
branch
4 times, most recently
from
4ced7ae to
53d4d57
Compare
February 21, 2024 20:12
pablogsal
commented
Feb 21, 2024
Comment thread
Modules/_testexternalinspection.c
Outdated
pablogsal
marked this pull request as draft
February 21, 2024 20:15
Comment thread
Modules/_testexternalinspection.c
pablogsal
force-pushed
the
external_inspection
branch
2 times, most recently
from
fdb96bf to
0de2132
Compare
February 21, 2024 22:06
pablogsal
marked this pull request as ready for review
February 21, 2024 23:28
pablogsal
commented
Feb 21, 2024
Comment thread
Modules/_testexternalinspection.c
Outdated
pablogsal
force-pushed
the
external_inspection
branch
from
5462e66 to
1b13cd9
Compare
February 22, 2024 08:45
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a4ebf4e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@erlend-aasland can you take a look? I think I have addressed all of the weird 32 bit failures |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'll take a look tonight by sunday! |
Sorry, something went wrong.
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Include/internal/pycore_runtime.h
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Modules/_testexternalinspection.c
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Modules/_testexternalinspection.c
Comment thread
Modules/_testexternalinspection.c
Outdated
Comment thread
Modules/_testexternalinspection.c
Outdated
pablogsal
commented
Feb 26, 2024
Comment thread
Modules/_testexternalinspection.c
Outdated
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
pablogsal
commented
Feb 26, 2024
Comment thread
Modules/_testexternalinspection.c
Outdated
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
approved these changes
Feb 27, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🚀
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 55bf6ac 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Did this break some JIT builds? See #116062 (comment) |
Sorry, something went wrong.
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Galindo pablogsal@gmail.com