FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-115942: Add `locked` to several multiprocessing locks by sobolevn · Pull Request #115944 · python/cpython · GitHub

/ cpython Public

gh-115942: Add locked to several multiprocessing locks - #115944

Merged
sobolevn merged 10 commits into
python:mainfrom
sobolevn:issue-115942
Apr 8, 2025
ConversationCommits (10)ChecksFiles changed
Merged

gh-115942: Add locked to several multiprocessing locks#115944
sobolevn merged 10 commits into
python:mainfrom
sobolevn:issue-115942

Conversation

sobolevn commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

TODO:

  • Get field-expert's approval
  • Docs
  • News

bedevere-app Bot mentioned this pull request Feb 26, 2024
Closed
sobolevn marked this pull request as ready for review March 13, 2024 06:44
sobolevn requested a review from gpshead as a code owner March 13, 2024 06:44

sobolevn commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

@gpshead do you have an opinion about this? :)

sobolevn commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

friendly ping @gpshead

mpage reviewed Jun 21, 2024
View reviewed changes
Comment thread Modules/_threadmodule.c Outdated
Update Modules/_threadmodule.c
646c650 
Co-authored-by: mpage <mpage@cs.stanford.edu>
vstinner reviewed Mar 13, 2025
View reviewed changes
Comment thread Modules/_threadmodule.c Outdated

gpshead commented Mar 13, 2025

Copy link
Copy Markdown
Member

FWIW this PR makes sense to me.

sobolevn commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Ok, then I will add all the missing details. Thanks a lot! 👍

picnixz reviewed Mar 13, 2025
View reviewed changes
Comment thread Lib/test/_test_multiprocessing.py
vstinner reviewed Apr 1, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add tests on threading.RLock.locked().

picnixz reviewed Apr 1, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just some rewording. Otherwise, once tests requested by Victor are added, LGTM.

Comment thread Doc/library/multiprocessing.rst Outdated
Comment thread Doc/library/multiprocessing.rst Outdated
Comment thread Doc/library/threading.rst Outdated
Comment thread Modules/_threadmodule.c Outdated

sobolevn commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

@vstinner @gpshead this is now ready to be reviewed :)

sobolevn requested review from mpage and vstinner April 1, 2025 09:43
picnixz approved these changes Apr 1, 2025
View reviewed changes
Comment thread Lib/threading.py Outdated
vstinner reviewed Apr 1, 2025
View reviewed changes
Comment thread Lib/importlib/_bootstrap.py
vstinner approved these changes Apr 1, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

hugovk reviewed Apr 7, 2025
View reviewed changes
Comment thread Doc/library/multiprocessing.rst Outdated
Comment thread Doc/library/multiprocessing.rst Outdated
Comment thread Doc/library/threading.rst Outdated
Comment thread Doc/library/threading.rst Outdated
Comment thread Lib/threading.py Outdated
Comment thread Modules/_threadmodule.c Outdated
Apply suggestions from code review
1a50a20 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
gpshead approved these changes Apr 8, 2025
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wish I could object to this being a locked() method instead of a .locked property... but this is matching an existing ancient API on purpose so... LGTM.

sobolevn merged commit f7305a0 into python:main Apr 8, 2025

sobolevn commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

Thanks everyone! 🎉

This was referenced Apr 15, 2025
Closed
Closed
YvesDup mentioned this pull request May 20, 2025
Closed
YvesDup mentioned this pull request Aug 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
gpshead gpshead approved these changes
vstinner vstinner approved these changes
picnixz picnixz approved these changes
mpage Awaiting requested review from mpage
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL