This is a change for the test, therefore as the devguide said, the news entry is not needed.

There are already quite a few news entries in the "Tests" section for the next 3.13 alpha, so I'm not clear what the convention is here.

Ah, you are right, so I'm not clear with this too now. 😂

Hi @erlend-aasland, could you please help us with this convention? Should we add a news entry for a test case fix or enhancement?

Normally, we don't require news entries for test changes, unless they are substansive.

OK, I've removed it.

@barneygale: Are you able to review this? It's a very simple change.

Looks good to me. Let's give @barneygale some days to chime in, before landing this.

(not a blocking issue:) I suppose infinite_recursion() is normally used to increase the recursion limit? It feels just a touch misleading to be calling it to reduce the recursion limit. Or perhaps I've misunderstood.

It's not a very accurate name, but it's already used in this way in many other places, so if we want to improve that I think it would be better done in a separate PR.

@barneygale, @mhsmith: perhaps also consider consolidating the test setup of test_glob_above_recursion_limit and test_walk_above_recursion_limit in a test helper.

@erlend-aasland I don't mind too much either way, but there's a decent argument that violating DRY in test code is a Good Thing: https://mtlynch.io/good-developers-bad-tests/

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.x has failed when building commit 2339e7c.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1225/builds/1698) and take a look at the build logs.
4. Check if the failure is related to this commit (2339e7c) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1225/builds/1698

Failed tests:

• test.test_multiprocessing_spawn.test_manager

Failed subtests:

• test_mymanager_context_prestarted - test.test_multiprocessing_spawn.test_manager.WithManagerTestMyManager.test_mymanager_context_prestarted

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_multiprocessing.py", line 3030, in test_mymanager_context_prestarted
    self.assertEqual(manager._process.exitcode, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: -15 != 0