FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-129467: turn off false-positive -Wstringop-overflow in word_to_string() by skirpichev · Pull Request #116346 · python/cpython · GitHub

/ cpython Public

gh-129467: turn off false-positive -Wstringop-overflow in word_to_string() - #116346

Merged
vstinner merged 4 commits into
python:mainfrom
skirpichev:decimal-io.c-off-stringop-overflow-108562
Jan 30, 2025
Merged

gh-129467: turn off false-positive -Wstringop-overflow in word_to_string()#116346
vstinner merged 4 commits into
python:mainfrom
skirpichev:decimal-io.c-off-stringop-overflow-108562

Conversation

skirpichev commented Mar 5, 2024
edited
Loading

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member Author

@skrah, could you take look on this variant of solving #108562? Attempt to enable -fstrict=overflow was unsuccessful, unfortunately.

rhettinger removed their request for review March 5, 2024 04:50

This comment was marked as outdated.

skirpichev commented Oct 6, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

@vstinner, maybe you could review this little pr? Note, that 4.0.0 has more diagnostic ignored (at top of the file):

#if defined(__GNUC__) && !defined(__INTEL_COMPILER) && __GNUC__ >= 7
  #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
  #pragma GCC diagnostic ignored "-Wmisleading-indentation"
  #pragma GCC diagnostic ignored "-Warray-bounds"
#endif

I turn of one diagnostic and more locally (with following pop directive).

Another option (mentioned in the issue) - update bundled copy.

vstinner commented Oct 7, 2024

Copy link
Copy Markdown
Member

Modules/_decimal/libmpdec/io.c

libmpdec/ is vendored copy of a 3rd party project. You should fix the issue in the upstream first. Otherwise, it will be lost at the next update.

See upstream: https://www.bytereef.org/mpdecimal/.

Copy link
Copy Markdown
Member Author

Ok, then I close pr and issue.

Unfortunately, @skrah blocked in python's repos. But he is aware about issue anyway.

skirpichev closed this Oct 7, 2024
skirpichev deleted the decimal-io.c-off-stringop-overflow-108562 branch October 7, 2024 12:31
skirpichev restored the decimal-io.c-off-stringop-overflow-108562 branch January 30, 2025 10:24
skirpichev reopened this Jan 30, 2025
skirpichev changed the title gh-108562: turn off false-positive -Wstringop-overflow in word_to_string() gh-129467: turn off false-positive -Wstringop-overflow in word_to_string() Jan 30, 2025
skirpichev marked this pull request as draft January 30, 2025 10:26
skirpichev marked this pull request as ready for review January 30, 2025 10:33
skirpichev requested a review from sobolevn January 30, 2025 10:49
vstinner merged commit 6c63afc into python:main Jan 30, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

skirpichev deleted the decimal-io.c-off-stringop-overflow-108562 branch January 30, 2025 11:08
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
…ython#116346)

Turn off false-positive -Wstringop-overflow in word_to_string().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL