gh-113538: Revert "gh-113538: Add asycio.Server.{close,abort}_clients (#114432)" - #116632
Merged
gvanrossum merged 1 commit intoMar 12, 2024
Merged
gh-113538: Revert "gh-113538: Add asycio.Server.{close,abort}_clients (#114432)"#116632gvanrossum merged 1 commit into
gvanrossum merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…hon#114432)" Reason: The new test doesn't always pass: python#116423 (comment) This reverts commit 1d0d49a.
gvanrossum
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
March 11, 2024 22:52
gvanrossum
enabled auto-merge (squash)
March 11, 2024 22:53
Copy link
Copy Markdown
Member
Author
|
I've set this to auto-merge since I may not be around later today. |
Sorry, something went wrong.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ort}_clients (python#114432)" (python#116632) Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)" Reason: The new test doesn't always pass: python#116423 (comment) This reverts commit 1d0d49a.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ort}_clients (python#114432)" (python#116632) Revert "pythongh-113538: Add asycio.Server.{close,abort}_clients (python#114432)" Reason: The new test doesn't always pass: python#116423 (comment) This reverts commit 1d0d49a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alas, we need to revert because the test doesn't always seem to pass.
@CendioOssman I hope you don't mind. We have a commitment to keep main free of test failures, and I don't know how to fix the test. :-(
📚 Documentation preview 📚: https://cpython-previews--116632.org.readthedocs.build/