FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-100746: Improve `test_named_expressions.py` by sobolevn · Pull Request #116713 · python/cpython · GitHub

/ cpython Public

gh-100746: Improve test_named_expressions.py - #116713

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-100746
Mar 13, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-100746: Improve test_named_expressions.py#116713
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-100746

Conversation

sobolevn commented Mar 13, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Two major changes:

  1. I removed pass where possible and instead used an assert for what we expect to happen
  2. I added dict-comprehensions testing by copy-pasting and modifing set-comprehension tests. Why? Because dict has key and value, we need to be sure that both work correctly.

bedevere-app Bot mentioned this pull request Mar 13, 2024
Closed
bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 13, 2024
emilyemorehouse approved these changes Mar 13, 2024
View reviewed changes

emilyemorehouse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great, thanks for getting more test coverage on this!

sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 13, 2024

sobolevn commented Mar 13, 2024

Copy link
Copy Markdown
Member Author

Backport to 3.12 will be as-is, while 3.11 will be much smaller, because 3.11 does not have new binding logic from 3.12

Eclips4 approved these changes Mar 13, 2024
View reviewed changes

Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

sobolevn merged commit 25684e7 into python:main Mar 13, 2024

miss-islington-app Bot commented Mar 13, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
pythongh-100746: Improve test_named_expressions.py (pythonGH-116713)
0b2e876 
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Mar 13, 2024

Copy link
Copy Markdown

GH-116747 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
pythongh-100746: Improve test_named_expressions.py (pythonGH-116713)
4e72e66 
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented Mar 13, 2024

Copy link
Copy Markdown

GH-116748 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 13, 2024
sobolevn added a commit that referenced this pull request Mar 13, 2024
[3.12] gh-100746: Improve test_named_expressions.py (GH-116713) (#1…
734c5c4 
…16747)

gh-100746: Improve `test_named_expressions.py` (GH-116713)
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
pythongh-100746: Improve test_named_expressions.py (python#116713)
41f5bc2
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
pythongh-100746: Improve test_named_expressions.py (python#116713)
69861cd
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-100746: Improve test_named_expressions.py (python#116713)
1e73fce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

emilyemorehouse emilyemorehouse approved these changes
Eclips4 Eclips4 approved these changes
pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL